Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3038: Filtering improvements #3165

Merged
merged 7 commits into from
May 9, 2019
Merged

Closes #3038: Filtering improvements #3165

merged 7 commits into from
May 9, 2019

Conversation

jeremystretch
Copy link
Member

Closes: #3038

  • Enable OR query logic when multiple values are passed for a filter
  • Remove the id__in filter from all models (use ?id=1&id=2 format instead)
  • Add miscellaneous missing fields to several models

@jeremystretch jeremystretch requested review from lampwins and DanSheps May 7, 2019 18:28
DanSheps
DanSheps approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

lampwins
lampwins reviewed May 8, 2019
View reviewed changes
Copy link
Contributor

@lampwins lampwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Would it be possible to maintain backward compatibility for id__in in 2.6? We have some precedent for this already and would be nice to do it here.

@jeremystretch
Copy link
Member Author

Restored id__in as suggested by @lampwins. Will remove it in v2.7.

@jeremystretch jeremystretch merged commit c24fb8d into develop-2.6 May 9, 2019
@jeremystretch jeremystretch deleted the 3038-filtering-improvements branch May 9, 2019 01:13
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lampwins lampwins lampwins left review comments

@DanSheps DanSheps DanSheps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremystretch @lampwins @DanSheps