Add rack name field to RackFilter #3188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to additional field it is now possible to select arbitrary racks for display e.g. in Rack Elevations view.
| @@ -128,6 +128,12 @@ class RackFilter(TenancyFilterSet, CustomFieldFilterSet): | |||
| queryset=Site.objects.all(), | |||
| label='Site (ID)', | |||
| ) | |||
| rack = django_filters.ModelMultipleChoiceFilter( | |||
There was a problem hiding this comment.
This doesn't make sense. The filterset is already being applied to the Rack model; the filter would just match on name. Support for multiple values was introduced in #3038 and will be available in v2.6.0.
There was a problem hiding this comment.
UI on v2.6-beta1 (d2c66d0baf91) doesn't seem to allow arbitrary rack selection. Changes from #3038 still need to surface to interface somehow.
I'm all ears for better way of achieving this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to additional field it is now possible to select arbitrary racks
for display e.g. in Rack Elevations view.
Fixes:
#3187