Filter on mac address on interface #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extension to be able filter on mac address via API
|
Per the pull request template, all PRs should have an issue opened for discussion prior to submission. In the future please open an issue first to avoid potentially wasting effort. |
netbox/dcim/filters.py
Outdated
| if not value: | ||
| return queryset | ||
| try: | ||
| return queryset.filter(mac_address=value).distinct() |
There was a problem hiding this comment.
.distinct() is unnecessary here. It's used in DeviceFilter to avoid returning duplicate Devices in the event a device has more than one interface with the same MAC address.
|
Thank you for your comment. |
Merged
lampwins
pushed a commit
to lampwins/netbox
that referenced
this pull request
Oct 13, 2017
Filter on mac address on interface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension to be able search by mac address of interface via API.
Just a small change, please merge it.