Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NSMBot commit message human-readable #64

Closed
denis-tingaikin opened this issue Apr 3, 2021 · 5 comments
Closed

Make NSMBot commit message human-readable #64

denis-tingaikin opened this issue Apr 3, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@denis-tingaikin
Copy link
Member

Motivation

Look at networkservicemesh/deployments-k8s#708 (comment)

As you can see commit message is not informative.

Potential solution

Each commit from NSM bot should link only to the previous PR (that triggered the current commit).

@denis-tingaikin denis-tingaikin changed the title Make NSMBot commit message human readable Make NSMBot commit message human-readable Apr 3, 2021
@denis-tingaikin denis-tingaikin added the bug Something isn't working label Apr 3, 2021
@Mixaster995
Copy link
Contributor

Mixaster995 commented Jul 30, 2021

Tried some formatting changes for nsm bot message. Tested this on 4 repositories chain.
Result messages looks like this:

Link - Mixaster995/test-actions-4#22

Image:

Screenshot 2021-07-30 at 14 25 36

Also made small fix for action retrieving pr number to work better.
I prepared changes for sdk repository: networkservicemesh/sdk#1041
and if it's ok, then i will made a batch of pr's for every repository.

@edwarnicke what do you think about this changes?

@edwarnicke
Copy link
Member

@Mixaster995 That looks amazing!

@Mixaster995
Copy link
Contributor

Mixaster995 commented Aug 2, 2021

Batch of PRs for changed message

api - networkservicemesh/api#111

sdk - networkservicemesh/sdk#1041
sdk-vpp - networkservicemesh/sdk-vpp#328
sdk-k8s - networkservicemesh/sdk-k8s#219
sdk-kernel - networkservicemesh/sdk-kernel#303
sdk-sriov - networkservicemesh/sdk-sriov#226

cmd-template - #79

deployments-k8s - networkservicemesh/deployments-k8s#2392
integration-tests - networkservicemesh/integration-tests#703
integration-k8s-kind - networkservicemesh/integration-k8s-kind#342
integration-k8s-gke - networkservicemesh/integration-k8s-gke#121

Don't have right to push to aks, aws, packet

denis-tingaikin added a commit to networkservicemesh/integration-k8s-aks that referenced this issue Aug 17, 2021
denis-tingaikin added a commit to networkservicemesh/integration-k8s-packet that referenced this issue Aug 17, 2021
denis-tingaikin added a commit to networkservicemesh/integration-k8s-aws that referenced this issue Aug 17, 2021
@denis-tingaikin
Copy link
Member Author

All PRs merged. So closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants