Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting change for NSMBot PR message #1041

Merged
merged 4 commits into from
Aug 8, 2021
Merged

Formatting change for NSMBot PR message #1041

merged 4 commits into from
Aug 8, 2021

Conversation

Mixaster995
Copy link
Contributor

@Mixaster995 Mixaster995 commented Jul 26, 2021 •
edited
Loading

Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com

Description

First step to make NSMBot messages more human-readable

Issue link

networkservicemesh/cmd-template#64

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@Mixaster995
added multiline PR comment
b1e9275 
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
@Mixaster995
reduced excessive repetitions, made short hash
50f4903 
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
@Mixaster995 Mixaster995 marked this pull request as draft July 27, 2021 07:14
@Mixaster995 Mixaster995 force-pushed the fix/nsm-bot-pr-message branch 2 times, most recently from 025befd to edddc8f Compare July 30, 2021 05:03
@Mixaster995
changed message formatting
f9eb5ac 
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
@Mixaster995 Mixaster995 force-pushed the fix/nsm-bot-pr-message branch 2 times, most recently from 7848fed to 42308eb Compare July 30, 2021 07:32
@Mixaster995 Mixaster995 mentioned this pull request Jul 30, 2021
Closed
@Mixaster995 Mixaster995 force-pushed the fix/nsm-bot-pr-message branch from 42308eb to 4cd7d9f Compare July 30, 2021 07:38
@Mixaster995 Mixaster995 marked this pull request as ready for review July 30, 2021 09:34
@Bolodya1997 Bolodya1997 self-requested a review July 30, 2021 10:06
@edwarnicke
Copy link
Member

@Mixaster995 Is this ready to merge?

@Bolodya1997
Copy link

@Mixaster995 Is this ready to merge?

@edwarnicke If you are OK with these changes, probably we want to wait for some time and add PRs to all other repositories to merge them in the same time.

@Mixaster995
fix for retrieving pr number
ff70d65 
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
@Mixaster995 Mixaster995 force-pushed the fix/nsm-bot-pr-message branch from 4cd7d9f to ff70d65 Compare August 2, 2021 04:40
denis-tingaikin
denis-tingaikin approved these changes Aug 8, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Mixaster995 Please apply this for all other repos.

@denis-tingaikin denis-tingaikin merged commit d5aa809 into networkservicemesh:main Aug 8, 2021
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Aug 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
811314a 
…k@main

PR link: networkservicemesh/sdk#1041

Commit: d5aa809
Author: Авраменко Михаил
Date: 2021-08-08 19:13:33 +0700
Message:
  - Formatting change for NSMBot PR message (#1041)
* added multiline PR comment

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* reduced excessive repetitions, made short hash

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* changed message formatting

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* fix for retrieving pr number

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Aug 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fee203b 
…k@main

PR link: networkservicemesh/sdk#1041

Commit: d5aa809
Author: Авраменко Михаил
Date: 2021-08-08 19:13:33 +0700
Message:
  - Formatting change for NSMBot PR message (#1041)
* added multiline PR comment

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* reduced excessive repetitions, made short hash

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* changed message formatting

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* fix for retrieving pr number

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Aug 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
26614f8 
…k@main

PR link: networkservicemesh/sdk#1041

Commit: d5aa809
Author: Авраменко Михаил
Date: 2021-08-08 19:13:33 +0700
Message:
  - Formatting change for NSMBot PR message (#1041)
* added multiline PR comment

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* reduced excessive repetitions, made short hash

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* changed message formatting

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* fix for retrieving pr number

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Aug 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5f4a158 
…k@main

PR link: networkservicemesh/sdk#1041

Commit: d5aa809
Author: Авраменко Михаил
Date: 2021-08-08 19:13:33 +0700
Message:
  - Formatting change for NSMBot PR message (#1041)
* added multiline PR comment

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* reduced excessive repetitions, made short hash

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* changed message formatting

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* fix for retrieving pr number

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b9e5d4b 
…k@main

PR link: networkservicemesh/sdk#1041

Commit: d5aa809
Author: Авраменко Михаил
Date: 2021-08-08 19:13:33 +0700
Message:
  - Formatting change for NSMBot PR message (#1041)
* added multiline PR comment

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* reduced excessive repetitions, made short hash

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* changed message formatting

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* fix for retrieving pr number

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Aug 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f22d52b 
…k@main

PR link: networkservicemesh/sdk#1041

Commit: d5aa809
Author: Авраменко Михаил
Date: 2021-08-08 19:13:33 +0700
Message:
  - Formatting change for NSMBot PR message (#1041)
* added multiline PR comment

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* reduced excessive repetitions, made short hash

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* changed message formatting

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* fix for retrieving pr number

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Aug 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cfa6386 
…k@main

PR link: networkservicemesh/sdk#1041

Commit: d5aa809
Author: Авраменко Михаил
Date: 2021-08-08 19:13:33 +0700
Message:
  - Formatting change for NSMBot PR message (#1041)
* added multiline PR comment

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* reduced excessive repetitions, made short hash

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* changed message formatting

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* fix for retrieving pr number

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Aug 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f4d4f14 
…k@main

PR link: networkservicemesh/sdk#1041

Commit: d5aa809
Author: Авраменко Михаил
Date: 2021-08-08 19:13:33 +0700
Message:
  - Formatting change for NSMBot PR message (#1041)
* added multiline PR comment

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* reduced excessive repetitions, made short hash

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* changed message formatting

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* fix for retrieving pr number

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Aug 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9428ab9 
…k@main

PR link: networkservicemesh/sdk#1041

Commit: d5aa809
Author: Авраменко Михаил
Date: 2021-08-08 19:13:33 +0700
Message:
  - Formatting change for NSMBot PR message (#1041)
* added multiline PR comment

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* reduced excessive repetitions, made short hash

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* changed message formatting

Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>

* fix for retrieving pr number

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Aug 8, 2021
Merged
This was referenced Aug 8, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
denis-tingaikin
denis-tingaikin reviewed Aug 9, 2021
View reviewed changes
.github/workflows/update-dependent-repositories-gomod.yaml
- name: Get sha
id: get-sha
run: |
echo ::set-output name=sha::$( curl -u "u:${{secrets.NSM_BOT_GITHUB_TOKEN}}" https://api.github.com/repos/networkservicemesh/sdk/git/ref/heads/main | jq .object.sha | tr -d '"' )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use GITHUB_SHA env. or for context ${{github.sha}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@Bolodya1997 Bolodya1997 Bolodya1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mixaster995 @edwarnicke @Bolodya1997 @denis-tingaikin