feat: Add "retry" networkservice.Client wrapper for nscs #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
10 tasks
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
add-retry-wrapper
branch
from
c104398
to
49fa488
Compare
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
edwarnicke
reviewed
Oct 31, 2021
| type Option func(*retryClient) | ||
|
|
||
| // WithSettings sets retry policy settings for the retry.Client instance. | ||
| func WithSettings(s Settings) Option { |
There was a problem hiding this comment.
Why not do this as standard options like
retry.WithInterval
retry.WithTryTimeout
instead of 'Settings'
edwarnicke
reviewed
Oct 31, 2021
|
|
||
| // Settings represents retry policy settings. | ||
| type Settings struct { | ||
| Timeout time.Duration |
There was a problem hiding this comment.
Why have timeout here instead of simply using the ctx passes into the RPC calls as normal?
edwarnicke
reviewed
Oct 31, 2021
| for ctx.Err() == nil { | ||
| requestCtx, cancel := c.WithTimeout(ctx, r.TryTimeout) | ||
| resp, err := r.client.Request(requestCtx, request, opts...) | ||
| cancel() |
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| cancel() | |
| defer cancel() |
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1129 Commit: 0eabc52 Author: Denis Tingaikin Date: 2021-11-02 04:35:19 +0300 Message: - feat: Add "retry" networkservice.Client wrapper for nscs (#1129) * add re-try networkservice.Client wrapper Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * update default values after manul testing Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1129 Commit: 0eabc52 Author: Denis Tingaikin Date: 2021-11-02 04:35:19 +0300 Message: - feat: Add "retry" networkservice.Client wrapper for nscs (#1129) * add re-try networkservice.Client wrapper Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * update default values after manul testing Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1129 Commit: 0eabc52 Author: Denis Tingaikin Date: 2021-11-02 04:35:19 +0300 Message: - feat: Add "retry" networkservice.Client wrapper for nscs (#1129) * add re-try networkservice.Client wrapper Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * update default values after manul testing Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1129 Commit: 0eabc52 Author: Denis Tingaikin Date: 2021-11-02 04:35:19 +0300 Message: - feat: Add "retry" networkservice.Client wrapper for nscs (#1129) * add re-try networkservice.Client wrapper Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * update default values after manul testing Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1129 Commit: 0eabc52 Author: Denis Tingaikin Date: 2021-11-02 04:35:19 +0300 Message: - feat: Add "retry" networkservice.Client wrapper for nscs (#1129) * add re-try networkservice.Client wrapper Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * update default values after manul testing Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1129 Commit: 0eabc52 Author: Denis Tingaikin Date: 2021-11-02 04:35:19 +0300 Message: - feat: Add "retry" networkservice.Client wrapper for nscs (#1129) * add re-try networkservice.Client wrapper Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * update default values after manul testing Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1129 Commit: 0eabc52 Author: Denis Tingaikin Date: 2021-11-02 04:35:19 +0300 Message: - feat: Add "retry" networkservice.Client wrapper for nscs (#1129) * add re-try networkservice.Client wrapper Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * update default values after manul testing Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1129 Commit: 0eabc52 Author: Denis Tingaikin Date: 2021-11-02 04:35:19 +0300 Message: - feat: Add "retry" networkservice.Client wrapper for nscs (#1129) * add re-try networkservice.Client wrapper Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * update default values after manul testing Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Issue link
#1123
How Has This Been Tested?
Types of changes