Upgrade go to v1.23 #1664
Merged
Upgrade go to v1.23 #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Ex4amp1e
force-pushed
the
upgrade-go-sources
branch
from
f6c83fe to
9a22853
Compare
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
| - G301 # Fixable | ||
| - G302 # Fixable | ||
| - G306 # Fixable | ||
| - G204 |
There was a problem hiding this comment.
Why are we excluding G204?
There was a problem hiding this comment.
G204 was included in exclude-rules list before, but on the current linter version we are getting too many new gosec errors, so decided to put them into one place- general config, not individually
There was a problem hiding this comment.
OK, add a todo and refer to the issue where we plan to fix these issues.
.golangci.yml
Outdated
| - interfacer | ||
| text: "`rawSrv` can be `github.com/networkservicemesh/sdk/pkg/networkservice/common/monitor.EventConsumer`" | ||
| - revive | ||
| # TODO - remove deprecated opentelemetry functions |
There was a problem hiding this comment.
Please add a ticket to refer here. Thanks.
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
denis-tingaikin
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Looks acceptable.
@NikitaSkrynnik Could you also have a look?
NikitaSkrynnik
approved these changes
Nov 19, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Nov 19, 2024
…k@main PR link: networkservicemesh/sdk#1664 Commit: cb2dbb0 Author: Vladislav Byrgazov Date: 2024-11-19 15:12:50 +0500 Message: - Upgrade go to v1.23 (#1664) * Upgrade go to v1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Add todo to fix linters Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 19, 2024
This was referenced Nov 19, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade go version
Proof of concept of working CI: Ex4amp1e#2 (using updated workflows)
Issue link
networkservicemesh/deployments-k8s#12294
How Has This Been Tested?
Types of changes