Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Vue preset's babel-preset-vue dependency is unused #836

Closed
edmorley opened this issue Apr 30, 2018 · 2 comments
Closed

Vue preset's babel-preset-vue dependency is unused #836

edmorley opened this issue Apr 30, 2018 · 2 comments

Comments

@edmorley
Copy link
Member

edmorley commented Apr 30, 2018 •
edited
Loading

The vue preset has a dependency on babel-preset-vue:
https://github.com/mozilla-neutrino/neutrino-dev/blob/6dee32757ee93ec1541124acd59b3c990f5ea853/packages/vue/package.json#L26

However as far as I can tell it's not actually being used:
https://github.com/mozilla-neutrino/neutrino-dev/blob/6dee32757ee93ec1541124acd59b3c990f5ea853/packages/vue/index.js#L11-L27

Should it be removed, or are we meant to be using it?

@helfi92, any ideas?
edmorley added a commit that referenced this issue May 3, 2018
@edmorley
Update to Babel 7
d7617a7 
Notable changes:
* All official packages have moved under the `@babel/` namespace and in
  some cases further renamed, so package names adjusted accordingly.
* `@babel/preset-env` now includes `@babel/plugin-transform-spread` and
  `@babel/plugin-transform-classes`, which are the Babel 7 renames of
  `babel-plugin-transform-object-rest-spread` and
  `babel-plugin-transform-es2015-classes`.
* `@babel/preset-env`'s `useBuiltIns: true` mode has been renamed to
  `useBuiltIns: 'entry'` - which is equivalent.
* `@babel/preset-react` now has `development` and `useBuiltIns` options,
  which we set appropriately:
  https://github.com/babel/babel/tree/v7.0.0-beta.46/packages/babel-preset-react#options
* `babel-plugin-dynamic-import-node` is no longer required by
  `@neutrinojs/library` for target `node`, since webpack converts the
  dynamic import to a require itself.
* `@neutrinojs/jest` required more substantial changes since:
  - the custom transformer used the now removed `canCompile()` from
    Babel's API.
  - `babel-preset-jest` is not fully compatible with Babel 7
    (jestjs/jest#6126).
* Several packages now have a peer dependency on `@babel/core`, so it's
  been added where necessary.
* `babel-loader` has been updated to v8 for Babel 7 compatibility.
* `@neutrinojs/vue`'s `babel-preset-vue` dependency doesn't appear to
  be used, but has been left as is pending #836.

Closes #316.
@edmorley edmorley mentioned this issue May 3, 2018
Merged
edmorley added a commit that referenced this issue May 6, 2018
@edmorley
Update to Babel 7
52a0f48 
Notable changes:
* All official packages have moved under the `@babel/` namespace and in
  some cases further renamed, so package names adjusted accordingly.
* `@babel/preset-env` now includes `@babel/plugin-transform-spread` and
  `@babel/plugin-transform-classes`, which are the Babel 7 renames of
  `babel-plugin-transform-object-rest-spread` and
  `babel-plugin-transform-es2015-classes`.
* `@babel/preset-env`'s `useBuiltIns: true` mode has been renamed to
  `useBuiltIns: 'entry'` - which is equivalent.
* `@babel/preset-react` now has `development` and `useBuiltIns` options,
  which we set appropriately:
  https://github.com/babel/babel/tree/v7.0.0-beta.46/packages/babel-preset-react#options
* `babel-plugin-dynamic-import-node` is no longer required by
  `@neutrinojs/library` for target `node`, since webpack converts the
  dynamic import to a require itself.
* `@neutrinojs/jest` required more substantial changes since:
  - the custom transformer used the now removed `canCompile()` from
    Babel's API.
  - `babel-preset-jest` is not fully compatible with Babel 7
    (jestjs/jest#6126).
* Several packages now have a peer dependency on `@babel/core`, so it's
  been added where necessary.
* `babel-loader` has been updated to v8 for Babel 7 compatibility.
* `@neutrinojs/vue`'s `babel-preset-vue` dependency doesn't appear to
  be used, but has been left as is pending #836.

Closes #316.
edmorley added a commit that referenced this issue May 7, 2018
@edmorley
Update to Babel 7 (#845)
e79fa15 
Notable changes:
* All official packages have moved under the `@babel/` namespace and in
  some cases further renamed, so package names adjusted accordingly.
* `@babel/preset-env` now includes `@babel/plugin-transform-spread` and
  `@babel/plugin-transform-classes`, which are the Babel 7 renames of
  `babel-plugin-transform-object-rest-spread` and
  `babel-plugin-transform-es2015-classes`.
* `@babel/preset-env`'s `useBuiltIns: true` mode has been renamed to
  `useBuiltIns: 'entry'` - which is equivalent.
* `@babel/preset-react` now has `development` and `useBuiltIns` options,
  which we set appropriately:
  https://github.com/babel/babel/tree/v7.0.0-beta.46/packages/babel-preset-react#options
* `babel-plugin-dynamic-import-node` is no longer required by
  `@neutrinojs/library` for target `node`, since webpack converts the
  dynamic import to a require itself.
* `@neutrinojs/jest` required more substantial changes since:
  - the custom transformer used the now removed `canCompile()` from
    Babel's API.
  - `babel-preset-jest` is not fully compatible with Babel 7
    (jestjs/jest#6126).
* Several packages now have a peer dependency on `@babel/core`, so it's
  been added where necessary.
* `babel-loader` has been updated to v8 for Babel 7 compatibility.
* `@neutrinojs/vue`'s `babel-preset-vue` dependency doesn't appear to
  be used, but has been left as is pending #836.

Closes #316.
@edmorley
Copy link
Member Author

edmorley commented May 8, 2018

@helfi92 as the creator of this preset, do you have any ideas? :-)

@helfi92
Copy link
Member

helfi92 commented May 8, 2018

I believe it can be deleted. PR on the way.

@helfi92 helfi92 mentioned this issue May 8, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edmorley @helfi92