Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Remove babel-preset-vue as it is not being used #860

Merged
merged 1 commit into from
May 8, 2018

Conversation

helfi92
Copy link
Member

@helfi92 helfi92 commented May 8, 2018

Resolves #836.

@helfi92 helfi92 self-assigned this May 8, 2018
@helfi92 helfi92 requested a review from edmorley May 8, 2018 20:57
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I finally found the part of the Vue docs that made this make sense: Vue JSX is an optional extra that many people using Vue won't need. (And confusingly the Vue docs only refer to babel-plugin-transform-vue-jsx and not babel-preset-vue, even though the babel-plugin-transform-vue-jsx install steps pretty much just duplicate babel-preset-vue?!)

@helfi92
Copy link
Member Author

helfi92 commented May 8, 2018

I think babel-preset-vue is supposed to be a preset for all vue plugins:

https://github.com/vuejs/babel-preset-vue/blob/b31b78f47f4ac39ce4d83aaa7c22b169d9e6010c/package.json#L33-L38

https://github.com/vuejs/babel-preset-vue/blob/b31b78f47f4ac39ce4d83aaa7c22b169d9e6010c/index.js

where babel-plugin-transform-vue-jsx is one of the included plugins.

@edmorley
Copy link
Member

edmorley commented May 8, 2018

Yeah but the usage instructions for babel-plugin-transform-vue-jsx are pretty much "install all the packages manually". But yet they have a parent package that includes all the other packages, the docs just don't mention it.

@helfi92
Copy link
Member Author

helfi92 commented May 8, 2018

I see what you mean. Yeah, that's odd :)

@helfi92 helfi92 merged commit a71a5b1 into neutrinojs:master May 8, 2018
@edmorley edmorley added this to the v9 milestone May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants