Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hovertaxibot #1852

Merged

Conversation

whatston3
Copy link
Contributor

About the PR

Adds a Hovertaxibot (pending a better name), essentially a taxibot that's space-capable. Available as a ghost role, it has a built in radar system (thanks, Leander), a horn, and moves as fast as a hoverbike. Like the taxibot, the rider cannot control it, only the person taking the ghost role can.

I created a new VehicleHornComponent for things that should have horns but are not vehicles (e.g. taxibots), because the rest of the sound emission is annoying.

Robots now use the pAI speech sounds (they should have something), and a few missing localization strings were added for taxibots (and some lingering ones removed).

Why / Balance

The Taxibot isn't very good for Frontier Station, it's mostly space. Enter the Hovertaxibot.

With regards to balance, there isn't much the ghost role can do outside of honk and fly around. A user may climb onboard a hovertaxibot and be flown immediately out of space and have them disconnect, but at that point, it seems like a user issue. Not terribly griefable, and the horn has the same cooldown as a normal vehicle's (same action).

I didn't like the tag added for the thruster board, but I figured it would make more sense to add some minor complexity to the construction graph.

How to test

  1. Construct a hoverbike, follow the in-game construction steps.
  2. Hop onboard.
  3. Connect in a separate client, join as an observer, join as the hovertaxibot.
  4. Note that no localization strings are missing from the description/name of the hovertaxibot, and you should be joining as a non-antag.
  5. Fly around, you should move like a hoverbike.
  6. Bring up your radar screen, it should work.
  7. Honk your horn, it should sound. Beep beep.
  8. Fly into space, you should still have control.
  9. Say something, you should make a noise like a pAI.
  10. Try to interact with the environment, you should not be able to.
  11. Run /ghost, your horn action should be gone.
  12. Spawn a taxibot, join as a taxibot.
  13. Note that no localization strings are missing from the description/name of the taxibot, and you should be joining as a non-antag.
  14. Honk your horn, it should sound. Beep beep.
  15. Say something, you should make a noise like a pAI.
  16. Run /ghost, your horn action should be gone.
  17. Spawn a mimebot, join as the mimebot.
  18. Say something (blasphemy), you should not make a sound.

Media

2024-08-12.08-18-10-out.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: The Hovertaxibot, a spacefaring taxi robot with a ghost role, is now craftable.

Copy link
Contributor

RSI Diff Bot; head commit 0405881 merging into 4291674
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Mobs/Silicons/Bots/hovertaxibot.rsi

State Old New Status
engines Added
hull Added
unshaded Added

@ErhardSteinhauer
Copy link
Contributor

Any chance you can add mass scanner as a action menu thingy to the hovertaxibot?

@whatston3
Copy link
Contributor Author

whatston3 commented Aug 12, 2024

Any chance you can add mass scanner as a action menu thingy to the hovertaxibot?

It has one. The recorded video is from the point of view of the moth. Probably should've taken it from the point of view of the bot - the bot has three actions: toggle mass scanner, honk your horn, and toggle your lights.

@ErhardSteinhauer
Copy link
Contributor

Guh. Not on the video.
Gotta check out the branch then I guess.

Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yml and ftl parts look sane, as a hovertaxibot you can honk, you can fly, you can't interact with anything (including wooden doors at Tinniya's). Dunno 'bout c#.

@ErhardSteinhauer ErhardSteinhauer merged commit 8102c6b into new-frontiers-14:master Aug 12, 2024
15 checks passed
FrontierATC added a commit that referenced this pull request Aug 12, 2024
@whatston3 whatston3 deleted the 2024-08-11-hovertaxibot branch September 21, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants