Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace calls to Timeout.timeout() #975

Closed
kaylareopelle opened this issue Feb 18, 2022 · 1 comment · Fixed by #2147
Closed

Replace calls to Timeout.timeout() #975

kaylareopelle opened this issue Feb 18, 2022 · 1 comment · Fixed by #2147
Assignees
@fallwith
Labels
1 Story Point Estimate enhancement Enhancement to existing features technical debt
Milestone
FY24Q2 Bug Smash ...

Comments

@kaylareopelle
Copy link
Contributor

kaylareopelle commented Feb 18, 2022 •
edited by angelatan2
Loading

Is your feature request related to a problem? Please describe.

Timeout.timeout() is no longer a recommended practice by the Ruby community as it is prone to unexpected behavior.

Feature Description

Replace Timeout.timeout() calls with more specific timeouts, as outlined in Mike Perham's article

Describe Alternatives

There is more than one way to replace Timeout.timeout, and we're open to additional solutions.

Priority

[Really Want]

###T-Shirt Size
@kaylareopelle kaylareopelle added enhancement Enhancement to existing features technical debt labels Feb 18, 2022
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-3422

@fallwith fallwith added this to the Feature smash! milestone Jun 5, 2023
@fallwith fallwith added the estimate Issue needing estimation label Jun 6, 2023
@kford-newrelic kford-newrelic added 1 Story Point Estimate and removed estimate Issue needing estimation labels Jun 10, 2023
@fallwith fallwith self-assigned this Jul 26, 2023
@fallwith fallwith moved this from To do to In progress in Ruby Engineering Board Jul 26, 2023
fallwith added a commit that referenced this issue Aug 1, 2023
@fallwith
don't use Timeout.timeout()
193ea5a 
(outside of `test/`) don't use `Timeout.timeout()` when the underlying
library has timeout functionality itself.

resolves #975
@fallwith fallwith mentioned this issue Aug 1, 2023
Merged
@github-project-automation github-project-automation bot moved this from In progress to Code Complete/Done in Ruby Engineering Board Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallwith fallwith

Labels
1 Story Point Estimate enhancement Enhancement to existing features technical debt
Projects
Ruby Engineering Board
Archived in project
Milestone
FY24Q2 Bug Smash & Tech Debt
Development

Successfully merging a pull request may close this issue.

don't use Timeout.timeout() newrelic/newrelic-ruby-agent
4 participants
@fallwith @kford-newrelic @hannahramadan @kaylareopelle