don't use Timeout.timeout() #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(outside of `test/`) don't use `Timeout.timeout()` when the underlying library has timeout functionality itself. resolves #975
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
CHANGELOG for issue 975
When yield phony AWS metadata checks, ignore all options sent to Net::HTTP beyond address and port.
tannalynn
reviewed
Aug 1, 2023
hannahramadan
previously approved these changes
Aug 1, 2023
* do not have Net::HTTP override OpenSSL specific timeouts * add TODOs to remind us to clean things up once we specifically only target Ruby versions 2.6 and above
SimpleCov Report
|
tannalynn
approved these changes
Aug 2, 2023
kaylareopelle
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Kudos to @fallwith and @tannalynn for your great discussion about this PR! It helped me a lot during my review.
fallwith
deleted the
it-s_too_bad_she_won-t_live_-_but_then_again_-_who_does
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(outside of
test/) don't useTimeout.timeout()when the underlying library has timeout functionality itself.resolves #975