Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rollup to new major 3.6 #110

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Update rollup to new major 3.6 #110

merged 1 commit into from
Dec 9, 2022

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 6, 2022

  • Updated rollup to new major version 3.x (3.6.0) and also updated corresponding dependencies
  • Adjusted tsconfig to run cypress using ES modules (ES2015 is the latest supported version by cypress 11)
  • Fixes / Supersedes Bump rollup from 2.79.1 to 3.2.5 #94

@skjnldsv skjnldsv added the 2. developing Work in progress label Dec 6, 2022
skjnldsv
skjnldsv reviewed Dec 6, 2022
View reviewed changes
tsconfig.json Show resolved Hide resolved
@susnux susnux force-pushed the feat/update-rollup branch 4 times, most recently from 37b0071 to 2147862 Compare December 6, 2022 19:13
@skjnldsv
Copy link
Contributor

skjnldsv commented Dec 6, 2022

Please do not upgrade cypress, this is broken
#11

@susnux
Copy link
Contributor Author

susnux commented Dec 6, 2022

Please do not upgrade cypress, this is broken #11

Had some hopes as at least 1 of 2 workflows succeeded

@skjnldsv
Copy link
Contributor

skjnldsv commented Dec 6, 2022

Had some hopes as at least 1 of 2 workflows succeeded

Me too. But this is also not related to this PR. Patchwork PRs should be avoided :)

@susnux
Copy link
Contributor Author

susnux commented Dec 8, 2022

The cypress tests now succeed, the issue was related to module handling which changed in rollup 2 -> 3 and node support in cypress (cypress 12 dropped node 12 support and modernized the builds to support node 14 / 16 and 18).

I guess the Node errors are unrelated?

@susnux susnux force-pushed the feat/update-rollup branch 3 times, most recently from 50bf930 to 8eea686 Compare December 8, 2022 20:38
@susnux susnux requested a review from skjnldsv December 8, 2022 20:39
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 8, 2022
@susnux
Copy link
Contributor Author

susnux commented Dec 8, 2022

I had to remove the node 14 test as node 14 fails with fsevents not accessible from chokidar
But I think this is not that bad, as it is not supported anymore by nextcloud anyways.

skjnldsv
skjnldsv requested changes Dec 8, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@susnux
Update rollup to new major 3.6.0, adjusted tsconfig
95c7459 
* Updated rollup to new major version 3.x (3.6.0)
  and also updated corresponding dependencies
* Adjusted tsconfig to run cypress using ES modules
  (ES2015 is the latest supported version by cypress 11)

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@susnux susnux requested a review from skjnldsv December 8, 2022 21:51
@skjnldsv skjnldsv merged commit 443a1d5 into master Dec 9, 2022
@skjnldsv skjnldsv deleted the feat/update-rollup branch December 9, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @skjnldsv