-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add related resources panel component #3081
Conversation
It should be working the same as for Files. replace |
82e5d47
to
a27989e
Compare
a27989e
to
5cc4640
Compare
Keeping as draft for now |
src/components/NcRelatedResourcesPanel/NcRelatedResourcesPanel.vue
Outdated
Show resolved
Hide resolved
src/components/NcRelatedResourcesPanel/NcRelatedResourcesPanel.vue
Outdated
Show resolved
Hide resolved
how about renaming from "related resources list" to just "resources list" ? it's just a name change and it already makes it more generic. having a component that is able to list resources can be useful in its own way (even if they are not "related") |
5cc4640
to
d297e01
Compare
There's no "related resources list" string do you mean renaming the component to |
d297e01
to
a028cd7
Compare
I meant that yes. But now going through the code I see that the logic is highly specific to that. I didn't think it would also contain the XHR requests for related resources and more logic. So the current code makes it very specific to related resources and is then reusable. I still have mixed feelings for having this here, wondering if it shouldn't then be a different nextcloud repo and lib. On the other hand a specific lib for just 1-2 components feels like overkill. So perhaps we just move forward with this for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
only one comment about accessible name
can also be resolved separately in case it becomes complicated
Signed-off-by: Christopher Ng <chrng8@gmail.com>
a028cd7
to
fc75afd
Compare
Yeah this solution as well as the alternative would incur the benefits and drawbacks detailed in nextcloud-libraries/nextcloud-vue-dashboard#407 |
Note we branched off a stable6 branch and master will be the next major only compatible with Nextcloud 25+, so if needed please backport this pr also to stable6. |
related resources is planned for NC 25 only, so probably no backport needed |
Add new component for nextcloud/server#28320
Screenshot (Shared items tab in Talk)
@ArtificialOwl since this component will be used in other apps how do we fetch the related resources of a Talk conversation, Deck board, Calendar event, et cetera?