Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add related resources panel to shared items sidebar #7789

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Add related resources panel to shared items sidebar #7789

merged 1 commit into from
Sep 15, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 24, 2022 •
edited
Loading

@Pytal Pytal added 3. to review feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Aug 24, 2022
@Pytal Pytal self-assigned this Aug 24, 2022
@nickvergessen nickvergessen added this to the 💚 Next Beta (25) milestone Aug 24, 2022
@Pytal Pytal mentioned this pull request Aug 25, 2022
Closed
7 tasks
@Pytal

This comment was marked as resolved.

Sign in to view
@marcoambrosini

This comment was marked as resolved.

Sign in to view
@nickvergessen

This comment was marked as resolved.

Sign in to view
@Pytal Pytal changed the base branch from master to bump/nextcloud-vue September 14, 2022 19:22
@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal Pytal marked this pull request as ready for review September 14, 2022 19:22
Base automatically changed from bump/nextcloud-vue to master September 14, 2022 20:19
@nickvergessen

This comment was marked as resolved.

Sign in to view
@nickvergessen nickvergessen added feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings enhancement and removed feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Sep 14, 2022
@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal Pytal mentioned this pull request Sep 14, 2022
Merged
@Pytal
Copy link
Member Author

Pytal commented Sep 14, 2022

Styles adjusted to fit more within the sidebar

image

Also needs nextcloud-libraries/nextcloud-vue#3259 for resource buttons to be styled correctly

@Pytal
Copy link
Member Author

Pytal commented Sep 14, 2022

After nextcloud-libraries/nextcloud-vue#3259 is merged and released this PR just needs a bump of nc/vue to the next beta

@PVince81 PVince81 mentioned this pull request Sep 15, 2022
Closed
@Pytal @nickvergessen
Add related resources panel
a81df76 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@nickvergessen nickvergessen merged commit b1a5ecc into master Sep 15, 2022
@nickvergessen nickvergessen deleted the enh/related-resources branch September 15, 2022 12:23
@Pytal
Copy link
Member Author

Pytal commented Sep 16, 2022

Note that another nc/vue beta will needed to fully fix the button styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 left review comments

@ArtificialOwl ArtificialOwl ArtificialOwl left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Pytal Pytal

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings high
Projects
None yet
Milestone
v15.0.0-beta.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Pytal @marcoambrosini @nickvergessen @PVince81 @ArtificialOwl @danxuliu