Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scssphp/scssphp from 1.0.3 to 1.0.9 #432

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps scssphp/scssphp from 1.0.3 to 1.0.9.

Release notes

Sourced from scssphp/scssphp's releases.

1.0.9

1.0.8

  • Import of valid scss files fails silently (@oyejorge, @Cerdic)
  • Undefined $libName (@enricobono, @robocoder)
  • Fix division and modulo per sass-spec (@Cerdic)
  • Fix expressions in at directives (@Cerdic)
  • Introduce support for custom properties (@Cerdic)
  • Function compatibility issues with functions (abs, ceil, floor, max, min, percentage, random, round), units, and conversions. (@Cerdic)

1.0.7

Changes:

1.0.6

1.0.5

Compatibility and Bug Fixes:

Maintenance:

  • phpunit test updates (@stof)
  • using is_null(), is_dir(), is_file() for consistency (@robocoder)

1.0.4

Bug fixes / Compatibility:

  • border-radius shorthand support (@alex-shul, @Cerdic)
  • allow zip() function to use all types as arguments (@devdot, @Cerdic)
  • @each forcing unwanted type conversion (@devdot)
  • rgb() and colour compatibility improvements (@Cerdic)
  • str-splice broken in php 7.4

Maintenance:

  • composer and travis configuration updates
... (truncated)
Commits
  • c6626ee Bump version to 1.0.9
  • 6cba707 Fix some parsig issue around +, - and --
  • 80f88fe Fix: # followed by a keyword is an acceptable value, even if it is not a color
  • 73dfcf0 Fix @import dir which import the existing dir/index.scss or dir/_index.scss
  • 9e2db1d Refs #88 - add vendor-prefixed glob() function
  • 61b22c1 Fix import of plain css file : this can happen only if no .scss ou _xxx.scss ...
  • fc2aada Fixes #87 - remove version and mbstring.func_overload checks
  • 9e7d2d6 Fix #86 : keep null as null when coercing a map to a list
  • c3a6f16 Fix #40 : custom properties with interpolation
  • 6ddf8f0 Some cleaning and rationalisation in the pushEnv()/popEnv() vs storeEnv :
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [scssphp/scssphp](https://github.com/scssphp/scssphp) from 1.0.3 to 1.0.9.
- [Release notes](https://github.com/scssphp/scssphp/releases)
- [Commits](scssphp/scssphp@1.0.3...1.0.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@kesselb
Copy link
Contributor

kesselb commented Apr 18, 2020

We need scssphp 1.0.8 for Nextcloud 19 otherwise people will still see those Trying to access array offset on value of type null warnings. I was able to trace (one of those warnings at least) down to the icon-color function. 1.0.3 is loosing the value for the color at some point and then runs into a npe. That's fixed with 1.0.8 luckily.

You can use the script below to reproduce it locally.

<?php

// broken
// composer require scssphp/scssphp:1.0.3 

// working
// composer require scssphp/scssphp:1.0.8

require 'vendor/autoload.php';

use ScssPhp\ScssPhp\Compiler;

$compiler = new Compiler();

$scss = <<<'SCSS'
/**
 * Removes the "#" from a color.
 *
 * @param string $color The color
 * @return string The color without #
 */
 @function remove-hash-from-color($color) {
    $index: str-index(inspect($color), '#');
    @if $index {
      $color: str-slice(inspect($color), 2);
    }
    @return $color;
  }
  
  /**
   * SVG COLOR API
   *
   * @param string $icon the icon filename
   * @param string $dir the icon folder within /core/img if $core or app name
   * @param string $color the desired color in hexadecimal
   * @param int $version the version of the file
   * @param bool [$core] search icon in core
   *
   * @returns A background image with the url to the set to the requested icon.
   */
  @mixin icon-color($icon, $dir, $color, $version: 1, $core: false) {
    $color: remove-hash-from-color($color);
    /* $dir is the app name, so we add this to the icon var to avoid conflicts between apps */
    $varName: "--icon-#{$dir}-#{$icon}-#{$color}";
    @if $core {
      $varName: "--icon-#{$icon}-#{$color}";
    }
    #{$varName}: url(icon-color-path($icon, $dir, $color, $version, $core));
    background-image: var(#{$varName});
  }
  
  .some-button {
    @include icon-color('confirm-fade', 'actions', '#fffffe', 2, true);
  }
SCSS;

echo $compiler->compile($scss);

@kesselb kesselb added this to the Nextcloud 19 milestone Apr 18, 2020
This was referenced Apr 21, 2020
@dependabot-preview
Copy link
Contributor Author

Superseded by #435.

@dependabot-preview dependabot-preview bot deleted the dependabot/composer/scssphp/scssphp-1.0.9 branch April 23, 2020 08:29
@ChristophWurst
Copy link
Member

We need scssphp 1.0.8 for Nextcloud 19 otherwise people will still see those Trying to access array offset on value of type null warnings.

Does it generally work for you? We get broken styling. See nextcloud/server#20713 (comment).

@kesselb
Copy link
Contributor

kesselb commented Apr 30, 2020

We get broken styling.

Good point ;) See the same broken styling with any scssphp version > 1.0.3. Likely I forgot to clear my cache properly. At least "Trying to access array offset on value of type null" was gone 🙈

@MorrisJobke
Copy link
Member

We need scssphp 1.0.8 for Nextcloud 19 otherwise people will still see those Trying to access array offset on value of type null warnings.

This is fixed in #441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants