Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3rdparty] Bump scssphp to 1.1.0 #20713

Closed
wants to merge 1 commit into from
Closed

[3rdparty] Bump scssphp to 1.1.0 #20713

wants to merge 1 commit into from

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Apr 29, 2020

@rullzer
[3rdparty] Bump scssphp to 1.1.0
15aabeb 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the Nextcloud 19 milestone Apr 29, 2020
@rullzer rullzer mentioned this pull request Apr 29, 2020
Merged
11 tasks
ChristophWurst
ChristophWurst requested changes Apr 30, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto von 2020-04-30 08-38-57

does not work for me

@rullzer
Copy link
Member Author

rullzer commented Apr 30, 2020

So this indeed breaks our styling hard.
Guess we need to fix that in a longer quest. Something for early 20

@rullzer rullzer modified the milestones: Nextcloud 19, Nextcloud 20 Apr 30, 2020
@ChristophWurst ChristophWurst mentioned this pull request Apr 30, 2020
Closed
@kesselb kesselb mentioned this pull request May 1, 2020
Closed
@J0WI J0WI mentioned this pull request Jun 10, 2020
Closed
1 task
@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
Merged
57 tasks
@rullzer rullzer closed this Aug 11, 2020
@rullzer rullzer deleted the 3rdparty/scssphp-1.1.0 branch August 11, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst requested changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: dependencies
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
2 participants
@rullzer @ChristophWurst