Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(translation): Add dev docs on OCP\Translation #10098

Merged
merged 1 commit into from
Apr 21, 2023
Merged

feat(translation): Add dev docs on OCP\Translation #10098

merged 1 commit into from
Apr 21, 2023

Conversation

marcelklehr
Copy link
Member

☑️ Resolves

🖼️ Screenshots

image

@ChristophWurst
Copy link
Member

/backport to stable26

ChristophWurst
ChristophWurst reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits

Very well written feature doc 👍

developer_manual/digging_deeper/translation.rst Outdated Show resolved Hide resolved
developer_manual/digging_deeper/translation.rst Show resolved Hide resolved
developer_manual/digging_deeper/translation.rst Show resolved Hide resolved
developer_manual/digging_deeper/translation.rst Outdated Show resolved Hide resolved
@marcelklehr
Copy link
Member Author

Screenshot

image

ChristophWurst
ChristophWurst approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome

please squash into a single commit

@marcelklehr
feat(translation): Add dev docs on OCP\Translation
7d34bba 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the feat/dev/translation branch from 6059300 to 7d34bba Compare April 21, 2023 08:56
@marcelklehr marcelklehr merged commit 790902d into master Apr 21, 2023
@marcelklehr marcelklehr deleted the feat/dev/translation branch April 21, 2023 09:03
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review manual: developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelklehr @ChristophWurst @nickvergessen