Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(translations): Add translation provider API #36584

Merged
merged 1 commit into from
Feb 27, 2023
Merged

feat(translations): Add translation provider API #36584

merged 1 commit into from
Feb 27, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 7, 2023 •
edited
Loading

Summary

TODO

  • Wrap registration into app bootstrap for lazyness
  • Clarify if defined API makes sense
  • Improve error handling

Checklist

@tcitworld
Copy link
Member

Most providers accept translating full documents, maybe add an extra interface for those?

@juliusknorr juliusknorr added this to the Nextcloud 26 milestone Feb 21, 2023
@juliusknorr
Copy link
Member Author

Most providers accept translating full documents, maybe add an extra interface for those?

Might be a nice idea for a follow up extension, for now I'd like to keep this PR as simple as possible.

julien-nc
julien-nc approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Apart from my small comments: 👍

lib/private/Translation/TranslationManager.php Outdated Show resolved Hide resolved
lib/private/Translation/TranslationManager.php Outdated Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@juliusknorr
feat(translations): Add translation provider API
3e63298 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added the 4. to release Ready to be released and/or waiting for tests to finish label Feb 27, 2023
@juliusknorr juliusknorr marked this pull request as ready for review February 27, 2023 16:28
@juliusknorr juliusknorr merged commit 6cfd53a into master Feb 27, 2023
@juliusknorr juliusknorr deleted the enh/translation-api branch February 27, 2023 18:45
@juliusknorr juliusknorr mentioned this pull request Feb 28, 2023
Merged
4 tasks
@blizzz blizzz mentioned this pull request Mar 2, 2023
Merged
@nickvergessen nickvergessen mentioned this pull request Apr 17, 2023
Merged
@nickvergessen
Copy link
Member

Missing API docs are in nextcloud/documentation#10047

@marcelklehr marcelklehr mentioned this pull request Apr 20, 2023
Closed
@marcelklehr marcelklehr mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

@marcelklehr marcelklehr marcelklehr approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusknorr @tcitworld @nickvergessen @marcelklehr @julien-nc