Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set icon size for buttons (we always use 20px) #133

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 27, 2024

  • Icons should always 20px as per our consistent design guidelines
  • No need to bind object to style if all properties are static, then just use the default string prop for styles

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review labels Jun 27, 2024
@susnux
Copy link
Contributor Author

susnux commented Jun 27, 2024

/compile

@susnux susnux mentioned this pull request Jun 27, 2024
1 task
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 615fad2 into main Jun 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants