feat: Add UI for removing keywords #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
approved these changes
Jun 27, 2024
|
Looks like this if you wonder:
|
|
Awesome work! Can't believe you went out of your way to improve on this app 💙 |
fix: Set icon size for buttons (we always use 20px)
Lists should have labels for accessibility to know the content of it. Also we call it classification rules in the UI but the remove label was "remove label" which is confusing. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Search keywords are populated but not possible to change using the UI, this allows to remove search keywords yet not to create new ones (use regex instead). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search keywords are populated but not possible to change using the UI, this allows to remove search keywords yet not to create new ones (use regex instead).
While we also might consider not populating the keywords when importing XML this PR allows to remove keywords for already existing setup!
This also fixes accessibility issues as lists should have labels for accessibility to know the content of it.
Also we call it classification rules in the UI but the remove label was "remove label" which is confusing.