fix nc branding

[ChristophWurst]

cc @nextcloud/mail

[MariusBluem]

Lets add "Nextcloud" here again 😉

[ChristophWurst]

sound like Let's make Mail great again 😉

[MariusBluem]

FIRST THE CORE, THEN THE MAIL APP AND LAST BUT NOT LEAST AMERICA 😈😅😆

cc @ChristophWurst

[MariusBluem]

Could we please put every screenshot into the screenshots repo 😁

[jancborchardt]

Yup, Marius is right, the screenshots should not clutter up the app repos. :) I opened a pull request in the screenshots repo: nextcloud/screenshots#20

@ChristophWurst can you remove the screenshot from here and amend the commit?

[ChristophWurst]

Yup, Marius is right, the screenshots should not clutter up the app repos. :) I opened a pull request in the screenshots repo: nextcloud/screenshots#20

@ChristophWurst can you remove the screenshot from here and amend the commit?

I don't think that would clutter the repo, it's just one file. Furthermore I find it quite handy to have it in the mail git repo as you can then go back and forth between releases and see the appropriate screenshot.

[irgendwie]

% grep -inrP '(?<!@)owncloud'

js/README.md:20:Generally, any code contributed to this repository should comply with the general ownCloud coding style guidelines.
[...]
lib/controller/aliasescontroller.php:5: * ownCloud - Mail
[...]

I think both lines should be adapted for Nextcloud! 👎

[jancborchardt]

@irgendwie good find! :) Do you want to fix them and add a commit?

[MariusBluem]

I don't think that would clutter the repo, it's just one file. Furthermore I find it quite handy to have it in the mail git repo as you can then go back and forth between releases and see the appropriate screenshot.

😕 ... I think it does not make sense to store a screenshot in the repo and a separate repo. We have also no screenshots in calendar/contacts or server repo. But thats only my opinion.
@ChristophWurst @jancborchardt

[MariusBluem]

Is there a reason of why we are not simply replacing that with Nextcloud - Mail ?! 😁 Does not matter anyway - but yeah 😅

[irgendwie]

@jancborchardt Done - my grep filtering also shows some more occurrences of ownCloud, but I think we can ignore them for now.

[jancborchardt]

I tend to agree with @Mar1u5 that we don’t really need to store the screenshots here as well. The screenshots repo has branches for releases as well and the look of the app doesn’t change that more often.

Anyway it’s your call @ChristophWurst. I adjusted the screenshot and compressed it.

[ChristophWurst]

thanks for the fixes @jancborchardt @irgendwie. Does this PR qualify for a 👍 now? LGTM is waiting for an approval comment 😛

[irgendwie]

Would say yes! LGTM 👍

[jancborchardt]

By the way, you are all invited to the Nextcloud conference, come register at https://conf.nextcloud.com :)
(If you didn't register yet or didn't submit a lightning talk yet. ;) cc @nextcloud/mail @Mar1u5 @zeugmatis

[zeugmatis]

Ah, I would totally go but I am in California! Just north of SF. Hope to try and sell NC here, but dropbox being free... is one tough competitor! Maybe same time next year. :-)

[jancborchardt]

@zeugmatis ooh cool! Maybe start a Nextcloud meetup there then? ;)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions.