Actions: Integration tests using bats #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
force-pushed
the
feature/actions/bats_tests
branch
2 times, most recently
from
a6673ff
to
122955e
Compare
anoymouserver
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Looks good to my unknowing eye. Nice sumarized output ..
Maybe unify the indentations in the .bats (mixed 2 and 4 spaces) and reference the used style in the .editorconfig in the root (if you're using VSCode you could install the matching extension)
SMillerDev
force-pushed
the
feature/actions/bats_tests
branch
from
122955e
to
a79ac30
Compare
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
============================================
+ Coverage 87.07% 87.16% +0.08%
- Complexity 691 693 +2
============================================
Files 60 60
Lines 2492 2485 -7
============================================
- Hits 2170 2166 -4
+ Misses 322 319 -3
Continue to review full report at Codecov.
|
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
SMillerDev
force-pushed
the
feature/actions/bats_tests
branch
from
a79ac30
to
1e69c40
Compare
Grotax
added a commit
that referenced
this pull request
Apr 3, 2021
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211)
Merged
Grotax
added a commit
that referenced
this pull request
Apr 3, 2021
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax
added a commit
that referenced
this pull request
Apr 3, 2021
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Changed - Add BATS as integration tests (nextcloud#1213) - Update FeedFetcher to import categories from feeds (nextcloud#1248) - Update serialization of item to include categories (nextcloud#1248) - Make PHPStan stricter (nextcloud#955) - Search: Add folder search (nextcloud#1215) - Improve test coverage (nextcloud#1263) - Allow directly adding a feed without going through the discovery process (nextcloud#1265) Fixed - Do not show deleted feeds in item list (nextcloud#1214) - Fix update queries (nextcloud#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do integration tests in bats instead of just running a script
Signed-off-by: Sean Molenaar sean@seanmolenaar.eu