Search: Add folder search #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous search implementation allowed to search for items (using the Filtering is apparently possible using the emitted events (which is currently undocumented): |
skjnldsv
reviewed
Mar 2, 2021
SMillerDev
force-pushed
the
feature/search/restore_folders
branch
from
0d51d28
to
8f511d5
Compare
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
SMillerDev
force-pushed
the
feature/search/restore_folders
branch
from
8f511d5
to
1541d7d
Compare
Grotax
approved these changes
Mar 26, 2021
SMillerDev
commented
Mar 29, 2021
SMillerDev
commented
Mar 29, 2021
SMillerDev
commented
Mar 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #1215 +/- ##
============================================
- Coverage 87.25% 86.51% -0.74%
- Complexity 701 708 +7
============================================
Files 60 61 +1
Lines 2519 2537 +18
============================================
- Hits 2198 2195 -3
- Misses 321 342 +21
Continue to review full report at Codecov.
|
Grotax
added a commit
that referenced
this pull request
Apr 3, 2021
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211)
Merged
Grotax
added a commit
that referenced
this pull request
Apr 3, 2021
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax
added a commit
that referenced
this pull request
Apr 3, 2021
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
* Search: Add folder search Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Changed - Add BATS as integration tests (nextcloud#1213) - Update FeedFetcher to import categories from feeds (nextcloud#1248) - Update serialization of item to include categories (nextcloud#1248) - Make PHPStan stricter (nextcloud#955) - Search: Add folder search (nextcloud#1215) - Improve test coverage (nextcloud#1263) - Allow directly adding a feed without going through the discovery process (nextcloud#1265) Fixed - Do not show deleted feeds in item list (nextcloud#1214) - Fix update queries (nextcloud#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds folder search to the unified search.
@nextcloud/news and @nextcloud/designers any opinions on what should be searchable in news? I'm currently thinking just feeds and folders.