Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix share link password input #12491

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Fix share link password input #12491

merged 1 commit into from
Nov 20, 2018

Conversation

skjnldsv
Copy link
Member

Fix #12308

Better layout, now clicking outside (which is often supposed to be a cancel action) won't do anything now.
Direct validation by enter key or click is what we want.

peek 16-11-2018 16-18

Also fixed the loading on the sharees autocompletion

Before After
capture d ecran_2018-11-16_15-55-41 capture d ecran_2018-11-16_15-57-00

@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Nov 16, 2018
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Nov 16, 2018
@skjnldsv skjnldsv self-assigned this Nov 16, 2018
@skjnldsv
Copy link
Member Author

Bump!

@skjnldsv skjnldsv added the high label Nov 20, 2018
ChristophWurst
ChristophWurst approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

MorrisJobke
MorrisJobke approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

JSUnit test fails:

PhantomJS 2.1.1 (Linux 0.0.0) OC.Share.ShareDialogView Share with link update password on focus out FAILED
	Expected false to equal true.
	core/js/tests/specs/sharedialogviewSpec.js:146:48
	TypeError: null is not an object (evaluating 'saveLinkShareStub.firstCall.args') in core/js/tests/specs/sharedialogviewSpec.js (line 147)
	core/js/tests/specs/sharedialogviewSpec.js:147:38

@skjnldsv
Fix share link password input
7a9ea03 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the share-menu-click-fix branch from 62d5017 to 7a9ea03 Compare November 20, 2018 13:40
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 20, 2018
@skjnldsv
Copy link
Member Author

JSunit ok: https://drone.nextcloud.com/nextcloud/server/12855/287
Failure unrelated

@skjnldsv skjnldsv merged commit ebc690b into master Nov 20, 2018
@skjnldsv skjnldsv deleted the share-menu-click-fix branch November 20, 2018 14:35
@nextcloud-bot nextcloud-bot mentioned this pull request Nov 20, 2018
Closed
@skjnldsv skjnldsv mentioned this pull request Nov 20, 2018
Merged
@skjnldsv
Copy link
Member Author

Backport: #12560

@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
7 tasks
@MorrisJobke MorrisJobke mentioned this pull request May 7, 2019
Closed
@nextcloud-bot nextcloud-bot mentioned this pull request Nov 16, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. high
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.

can't see the warning about a wrong password when sharing by email
4 participants
@skjnldsv @MorrisJobke @jancborchardt @ChristophWurst