Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Fix share link password input #12560

Merged
merged 1 commit into from
Nov 23, 2018
Merged

[stable14] Fix share link password input #12560

merged 1 commit into from
Nov 23, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 20, 2018 •
edited
Loading

Backport of #12491

@skjnldsv skjnldsv added this to the Nextcloud 14.0.4 milestone Nov 20, 2018
@skjnldsv skjnldsv self-assigned this Nov 20, 2018
@skjnldsv skjnldsv mentioned this pull request Nov 20, 2018
Merged
@skjnldsv skjnldsv added the high label Nov 20, 2018
@MorrisJobke
Copy link
Member

14.0.5 it will be ;)

@skjnldsv skjnldsv force-pushed the stb14-share-menu-click-fix branch from 70fe9f9 to 5ecf634 Compare November 22, 2018 20:58
@skjnldsv
Fix share link password input
d8a8c03 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the stb14-share-menu-click-fix branch from 5ecf634 to d8a8c03 Compare November 22, 2018 20:59
@rullzer
Copy link
Member

rullzer commented Nov 23, 2018

14.0.5 it will be ;)

So review it 😉

MorrisJobke
MorrisJobke approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit b289150 into stable14 Nov 23, 2018
@MorrisJobke MorrisJobke deleted the stb14-share-menu-click-fix branch November 23, 2018 07:46
@MorrisJobke MorrisJobke mentioned this pull request Jan 4, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: sharing high
Projects
None yet
Milestone
Nextcloud 14.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @MorrisJobke @rullzer