Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for triple dots in translations in CI #20321

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

gary-kim
Copy link
Member

@gary-kim gary-kim commented Apr 5, 2020

Check translations for triple dots. So @rakekniven isn't having to constantly fix it :).

@gary-kim gary-kim force-pushed the enh/noid/check-translation-for-triple-dot branch 2 times, most recently from 74e2714 to 3592922 Compare April 5, 2020 12:39
@gary-kim gary-kim added this to the Nextcloud 19 milestone Apr 5, 2020
@gary-kim gary-kim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 5, 2020
@gary-kim gary-kim force-pushed the enh/noid/check-translation-for-triple-dot branch from 3592922 to f13aa6c Compare April 6, 2020 05:50
@gary-kim gary-kim force-pushed the enh/noid/check-translation-for-triple-dot branch from f13aa6c to 411d99e Compare April 7, 2020 02:46
Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim gary-kim force-pushed the enh/noid/check-translation-for-triple-dot branch from 411d99e to 283b8a5 Compare April 7, 2020 04:07
@rullzer rullzer mentioned this pull request Apr 7, 2020
80 tasks
@rakekniven
Copy link
Member

Check translations for triple dots. So @rakekniven isn't having to constantly fix it :).

Hello @gary-kim You are my hero :-) Thank you very much.

continue;
}
$content = file_get_contents($file->getPathname());
$matches = preg_grep('/[^A-Za-z][tn]\([\'"][^\'"]*?[\'"],( ?)[\'"][^\'"]*?(\.\.\.)[^\'"]*?[\'"]/sU', explode(PHP_EOL, $content));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen nickvergessen merged commit bbba7bc into master Apr 8, 2020
@nickvergessen nickvergessen deleted the enh/noid/check-translation-for-triple-dot branch April 8, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants