-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for triple dots in translations in CI #20321
Merged
nickvergessen
merged 1 commit into
master
from
enh/noid/check-translation-for-triple-dot
Apr 8, 2020
Merged
Check for triple dots in translations in CI #20321
nickvergessen
merged 1 commit into
master
from
enh/noid/check-translation-for-triple-dot
Apr 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-kim
force-pushed
the
enh/noid/check-translation-for-triple-dot
branch
2 times, most recently
from
April 5, 2020 12:39
74e2714
to
3592922
Compare
gary-kim
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Apr 5, 2020
gary-kim
force-pushed
the
enh/noid/check-translation-for-triple-dot
branch
from
April 6, 2020 05:50
3592922
to
f13aa6c
Compare
gary-kim
force-pushed
the
enh/noid/check-translation-for-triple-dot
branch
from
April 7, 2020 02:46
f13aa6c
to
411d99e
Compare
Signed-off-by: Gary Kim <gary@garykim.dev>
gary-kim
force-pushed
the
enh/noid/check-translation-for-triple-dot
branch
from
April 7, 2020 04:07
411d99e
to
283b8a5
Compare
Hello @gary-kim You are my hero :-) Thank you very much. |
rullzer
approved these changes
Apr 8, 2020
continue; | ||
} | ||
$content = file_get_contents($file->getPathname()); | ||
$matches = preg_grep('/[^A-Za-z][tn]\([\'"][^\'"]*?[\'"],( ?)[\'"][^\'"]*?(\.\.\.)[^\'"]*?[\'"]/sU', explode(PHP_EOL, $content)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
nickvergessen
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check translations for triple dots. So @rakekniven isn't having to constantly fix it :).