Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for triple dots in translations in CI #20321

Merged
merged 1 commit into from
Apr 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions autotest-checkers.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ bash ./build/autoloaderchecker.sh
RESULT=$(($RESULT+$?))
php ./build/translation-checker.php
RESULT=$(($RESULT+$?))
php ./build/triple-dot-checker.php
RESULT=$(($RESULT+$?))
php ./build/htaccess-checker.php
RESULT=$(($RESULT+$?))
bash ./build/ca-bundle-checker.sh
Expand Down
63 changes: 63 additions & 0 deletions build/triple-dot-checker.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
<?php
/**
* @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com>
* @copyright Copyright (c) 2020 Gary Kim <gary@garykim.dev>
*
* @author Gary Kim <gary@garykim.dev>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

$directories = [
__DIR__ . '/../apps',
__DIR__ . '/../core'
];

$errors = [];
foreach ($directories as $dir) {
$it = new \RecursiveDirectoryIterator($dir);

foreach (new RecursiveIteratorIterator($it) as $file) {
if ($file->getExtension() === 'map') {
continue;
}
$content = file_get_contents($file->getPathname());
$matches = preg_grep('/[^A-Za-z][tn]\([\'"][^\'"]*?[\'"],( ?)[\'"][^\'"]*?(\.\.\.)[^\'"]*?[\'"]/sU', explode(PHP_EOL, $content));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀


foreach ($matches as $ln => $match) {
if (file_exists($file->getPathname() . '.map')) {
$errors[] = sprintf('At line %d in file %s (file may be transpiled)', $ln, $file);
} else {
$errors[] = sprintf('At line %d in file %s', $ln, $file);
}
}
}
}

echo PHP_EOL . PHP_EOL;
if (count($errors) > 0) {
if (count($errors) > 1) {
echo sprintf('ERROR: There are %d uses of triple dot instead of ellipsis:', count($errors)) . PHP_EOL;
} else {
echo 'ERROR: There is 1 use of triple dot instead of ellipsis:' . PHP_EOL;
}
echo implode(PHP_EOL, $errors) . PHP_EOL;
exit(1);
}

echo 'OK: all good! No use of triple dot instead of ellipsis found.' . PHP_EOL;
exit(0);