Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump scssphp/scssphp from 1.0.3 to 1.1.1 #21300

Closed
wants to merge 1 commit into from
Closed

Bump scssphp/scssphp from 1.0.3 to 1.1.1 #21300

wants to merge 1 commit into from

Conversation

ChristophWurst
Copy link
Member

This is the first scssphp bump that does not completely break our overall design, yay.

@ChristophWurst
Bump scssphp/scssphp from 1.0.3 to 1.1.1
3bb95ca 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 20 milestone Jun 8, 2020
@ChristophWurst ChristophWurst self-assigned this Jun 8, 2020
@kesselb
Copy link
Contributor

kesselb commented Jun 8, 2020

image

  1. Checkout dependabot/composer/scssphp/scssphp-1.1.1
  2. Run git submodule update --init
  3. Run occ maintenance:repair

🤷‍♂️ 😕

@ChristophWurst
Copy link
Member Author

I just had this minor issue nextcloud/3rdparty#456 (review)

@ChristophWurst
Copy link
Member Author

I also ran occ maintenance:repair. Does that help?

@kesselb
Copy link
Contributor

kesselb commented Jun 9, 2020

I run maintenance:repair. Maybe it's a issue with my dev setup. Let's see if anyone else can reproduce :)

@J0WI
Copy link
Contributor

J0WI commented Jun 10, 2020

See also #20713 and #19825

@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
Merged
57 tasks
@skjnldsv
Copy link
Member

skjnldsv commented Nov 6, 2020

Pwet

@rullzer rullzer mentioned this pull request Dec 14, 2020
Merged
59 tasks
@ChristophWurst
Copy link
Member Author

stale and needs to be redone

@MichaIng MichaIng deleted the dependabot/composer/scssphp/scssphp-1.1.1 branch July 15, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb Awaiting requested review from kesselb

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@gary-kim gary-kim Awaiting requested review from gary-kim

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews feature: dependencies
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @kesselb @J0WI @skjnldsv @MorrisJobke