Phone number validation and search #24486

nickvergessen · 2020-12-01T15:00:32Z

Use https://giggsey.com/libphonenumber/ to find valid testing numbers

Search API

Endpoint: POST ocs/v2.php/cloud/users/search/by-phone
Data (all 3 number formats are valid):

{
	"location": "DE",
	"search": {
		"Unique-Idenifier-For-Contact-1": [
			"0711/25 24 28-90"
		],
		"Unique-Idenifier-For-Contact-2": [
			"+49 711/25 24 28-91",
			"0049 711/25 24 28-92"
		]
	}
}

Response (map of provided identifier and cloudId):

{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 200,
      "message": "OK"
    },
    "data": {
      "Unique-Idenifier-For-Contact-1": "admin@localhost/"
    }
  }
}

nickvergessen · 2020-12-02T16:18:40Z

As per opening post, the lib to validate/unify phone numbers needs a default region.

Best I have in mind is an admin setup warning about the missing region and until that is set only allow +49 phone numbers and lie to the lib that the default region is EN. Falling back to default language "would also work", but e.g. Austrian numbers would be German as they use the same language, so it's not very sensitive/accurate.

Opinions on this? @MorrisJobke @rullzer @ChristophWurst

ChristophWurst · 2020-12-02T18:52:00Z

As per opening post, the lib to validate/unify phone numbers needs a default region.

Would the locale be more accurate than the language? Like if one sets de_AT then you can guess the country. Possible not 100% accurate either but it seems like there is a locale for many countries.

MorrisJobke · 2020-12-02T20:04:33Z

Best I have in mind is an admin setup warning about the missing region and until that is set only allow +49 phone numbers and lie to the lib that the default region is EN.

Doesn't sound too bad IMO.

nickvergessen · 2020-12-03T19:44:20Z

Anyone an idea about:

Need a way to retrigger a full sync of the accounts table

Signed-off-by: Joas Schilling <coding@schilljs.com>

…er API directly Signed-off-by: Joas Schilling <coding@schilljs.com>

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen · 2020-12-07T15:37:39Z

Added a repairstep to validate the existing entries. This is now ready to review.

Signed-off-by: Joas Schilling <coding@schilljs.com>

faily-bot · 2020-12-08T12:47:29Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 299: failure

sqlite

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 4 failures:

1) Test\Preview\BitmapTest::testGetThumbnail with data set #0 (-30, -74)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

2) Test\Preview\BitmapTest::testGetThumbnail with data set #1 (48, 95)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

3) Test\Preview\BitmapTest::testGetThumbnail with data set #2 (-64, 13)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

4) Test\Preview\BitmapTest::testGetThumbnail with data set #3 (57, -93)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

mariadb10.4-php7.4

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 4 failures:

1) Test\Preview\BitmapTest::testGetThumbnail with data set #0 (-63, -90)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

2) Test\Preview\BitmapTest::testGetThumbnail with data set #1 (30, 20)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

3) Test\Preview\BitmapTest::testGetThumbnail with data set #2 (-27, 81)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

4) Test\Preview\BitmapTest::testGetThumbnail with data set #3 (73, -37)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

mysql8.0-php7.4

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 4 failures:

1) Test\Preview\BitmapTest::testGetThumbnail with data set #0 (-63, -99)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

2) Test\Preview\BitmapTest::testGetThumbnail with data set #1 (17, 54)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

3) Test\Preview\BitmapTest::testGetThumbnail with data set #2 (-98, 25)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

4) Test\Preview\BitmapTest::testGetThumbnail with data set #3 (92, -10)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

postgres11-php7.4

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 4 failures:

1) Test\Preview\BitmapTest::testGetThumbnail with data set #0 (-26, -83)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

2) Test\Preview\BitmapTest::testGetThumbnail with data set #1 (44, 10)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

3) Test\Preview\BitmapTest::testGetThumbnail with data set #2 (-92, 80)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

4) Test\Preview\BitmapTest::testGetThumbnail with data set #3 (52, -72)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

nickvergessen added enhancement 2. developing Work in progress 3. to review Waiting for reviews feature: settings labels Dec 1, 2020

nickvergessen added this to the Nextcloud 21 milestone Dec 1, 2020

nickvergessen removed the 3. to review Waiting for reviews label Dec 1, 2020

nickvergessen force-pushed the feature/noid/phone-number-validation branch 2 times, most recently from e25ca41 to 0d63b89 Compare December 2, 2020 16:01

nickvergessen changed the title ~~Phone number validation~~ Phone number validation and search Dec 2, 2020

nickvergessen force-pushed the feature/noid/phone-number-validation branch 2 times, most recently from 0fd3621 to f543a19 Compare December 3, 2020 13:11

nickvergessen requested review from ChristophWurst, MorrisJobke and rullzer December 3, 2020 19:43

nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 3, 2020

nickvergessen marked this pull request as ready for review December 3, 2020 19:46

nickvergessen force-pushed the feature/noid/phone-number-validation branch 3 times, most recently from 6b4bac2 to d6e3367 Compare December 4, 2020 09:03

nickvergessen mentioned this pull request Dec 7, 2020

Bump icewind/streams from 0.7.1 to 0.7.2 #24533

Merged

2 tasks

nickvergessen added 5 commits December 7, 2020 14:19

Make code strict

da9462b

Signed-off-by: Joas Schilling <coding@schilljs.com>

Also return the phone number and twitter handle on the API

c2913f1

Signed-off-by: Joas Schilling <coding@schilljs.com>

Bump 3rdparty to include giggsey/libphonenumber-for-php

e17cd8a

Signed-off-by: Joas Schilling <coding@schilljs.com>

Display errors that happen on saving

570c1bf

Signed-off-by: Joas Schilling <coding@schilljs.com>

Validate and standardize the phone number on saving

efe79f2

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen added 8 commits December 7, 2020 14:19

Add a database table for the accounts data so we can search it better

eaba155

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add an endpoint to search for accounts based on phone number

fe9c46e

Signed-off-by: Joas Schilling <coding@schilljs.com>

Also translate the phone number when coming in via the accounts manag…

9e04e6f

…er API directly Signed-off-by: Joas Schilling <coding@schilljs.com>

Add an integration test for the phone search API

689e3a5

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add a config for default region of phone numbers

46b073d

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add and fix unit tests

f0ca76a

Signed-off-by: Joas Schilling <coding@schilljs.com>

Make the throwing optional, so background tasks don't break

f648635

Signed-off-by: Joas Schilling <coding@schilljs.com>

Unit tests for searching by phone number

d0750df

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen force-pushed the feature/noid/phone-number-validation branch from d6e3367 to d0750df Compare December 7, 2020 13:19

Add a repairstep to validate the phone numbers

354c5ff

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen force-pushed the feature/noid/phone-number-validation branch from 22576e7 to 354c5ff Compare December 7, 2020 19:36

Fix PHP code style

13a438b

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen requested review from juliusknorr and removed request for MorrisJobke December 8, 2020 12:11

rullzer approved these changes Dec 8, 2020

View reviewed changes

juliusknorr approved these changes Dec 8, 2020

View reviewed changes

juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 8, 2020

nickvergessen merged commit 86a3b7e into master Dec 8, 2020

nickvergessen deleted the feature/noid/phone-number-validation branch December 8, 2020 16:05

nickvergessen mentioned this pull request Dec 8, 2020

Bump 3rdparty from e287243 to 27a56c5 #24602

Closed

simonspa mentioned this pull request Apr 12, 2021

Phone number can't be set at user profile #25931

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phone number validation and search #24486

Phone number validation and search #24486

nickvergessen commented Dec 1, 2020 •

edited

Loading

nickvergessen commented Dec 2, 2020

ChristophWurst commented Dec 2, 2020

MorrisJobke commented Dec 2, 2020

nickvergessen commented Dec 3, 2020

nickvergessen commented Dec 7, 2020

faily-bot bot commented Dec 8, 2020

Phone number validation and search #24486

Phone number validation and search #24486

Conversation

nickvergessen commented Dec 1, 2020 • edited Loading

Search API

nickvergessen commented Dec 2, 2020

ChristophWurst commented Dec 2, 2020

MorrisJobke commented Dec 2, 2020

nickvergessen commented Dec 3, 2020

nickvergessen commented Dec 7, 2020

faily-bot bot commented Dec 8, 2020

Status of 299: failure

sqlite

mariadb10.4-php7.4

mysql8.0-php7.4

postgres11-php7.4

nickvergessen commented Dec 1, 2020 •

edited

Loading