Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phone number validation and search #24486

Merged
merged 15 commits into from
Dec 8, 2020
Merged

Phone number validation and search #24486

merged 15 commits into from
Dec 8, 2020

Commits on Dec 7, 2020

  1. Make code strict 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    da9462b View commit details
    Browse the repository at this point in the history

  2. Also return the phone number and twitter handle on the API 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    c2913f1 View commit details
    Browse the repository at this point in the history

  3. Bump 3rdparty to include giggsey/libphonenumber-for-php 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    e17cd8a View commit details
    Browse the repository at this point in the history

  4. Display errors that happen on saving 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    570c1bf View commit details
    Browse the repository at this point in the history

  5. Validate and standardize the phone number on saving 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    efe79f2 View commit details
    Browse the repository at this point in the history

  6. Add a database table for the accounts data so we can search it better 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    eaba155 View commit details
    Browse the repository at this point in the history

  7. Add an endpoint to search for accounts based on phone number 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    fe9c46e View commit details
    Browse the repository at this point in the history

  8. Also translate the phone number when coming in via the accounts manag… 

    …er API directly

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    9e04e6f View commit details
    Browse the repository at this point in the history

  9. Add an integration test for the phone search API 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    689e3a5 View commit details
    Browse the repository at this point in the history

  10. Add a config for default region of phone numbers 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    46b073d View commit details
    Browse the repository at this point in the history

  11. Add and fix unit tests 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    f0ca76a View commit details
    Browse the repository at this point in the history

  12. Make the throwing optional, so background tasks don't break 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    f648635 View commit details
    Browse the repository at this point in the history

  13. Unit tests for searching by phone number 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    d0750df View commit details
    Browse the repository at this point in the history

  14. Add a repairstep to validate the phone numbers 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    354c5ff View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Fix PHP code style 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    13a438b View commit details
    Browse the repository at this point in the history