-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the user language when adding the footer #24999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliusknorr
commented
Jan 7, 2021
- Create a new user and set the language to something different than the default
- See that the footer of the welcome email is not in the expected user language
juliusknorr
requested review from
rullzer,
nickvergessen,
ChristophWurst and
skjnldsv
January 7, 2021 09:43
/backport to stable20 |
rullzer
approved these changes
Jan 7, 2021
ChristophWurst
approved these changes
Jan 7, 2021
Conflicts! |
juliusknorr
force-pushed
the
bugfix/noid/email-footer-language
branch
from
January 7, 2021 14:29
04aebdd
to
1dc8bba
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/email-footer-language
branch
from
January 7, 2021 14:32
1dc8bba
to
068e3b2
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1109: failuremariadb10.1-php7.3Show full log
acceptance-users
Show full log
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.