Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Set the user language when adding the footer #25019

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 7, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #24999

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the backport/24999/stable20 branch from fd775c9 to 3638808 Compare January 8, 2021 09:09
@faily-bot
Copy link

faily-bot bot commented Jan 8, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1169: failure

mysql5.6-php7.2

Show full log
There was 1 error:

1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testCreate
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:869
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:244
/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:189

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testDeleteFromSelfGroupDoesNotExist
Failed asserting that exception of type "OCP\Share\Exceptions\ShareNotFound" matches expected exception "OC\Share20\Exception\ProviderException". Message was: "There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted." at
/drone/src/lib/private/Share20/DefaultShareProvider.php:763
/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1641
.

acceptance-app-files-sharing-link

  • tests/acceptance/features/app-files-sharing-link.feature:135
Show full log
  Scenario: access a shared link protected by password with a valid password                   # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:135
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
      Share link menu trigger in the details view in Files app could not be found after 20 seconds (NoSuchElementException)
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the shared link I wrote down  # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
    And I authenticate with password "abcdef"                                                  # PublicShareContext::iAuthenticateWithPassword()
    Then I see that the current page is the shared link I wrote down                           # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I see that the shared file preview shows the text "Welcome to your Nextcloud account!" # PublicShareContext::iSeeThatTheSharedFilePreviewShowsTheText()

@rullzer rullzer mentioned this pull request Jan 11, 2021
1 task
@MorrisJobke
Copy link
Member

Psalm fix is in #25066

@MorrisJobke MorrisJobke merged commit 08f6444 into stable20 Jan 11, 2021
@MorrisJobke MorrisJobke deleted the backport/24999/stable20 branch January 11, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants