Fix broken Calendar Event Invite email icons in Gmail by using PNGs instead of SVGs #26342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirate
changed the title
Signed-off-by: Nick Sweeting <git@sweeting.me>
st3iny
added
3. to review
st3iny
requested review from
tcitworld,
julien-nc,
juliusknorr,
kesselb and
ChristophWurst
ChristophWurst
approved these changes
Mar 29, 2021
tcitworld
approved these changes
Mar 29, 2021
ChristophWurst
added
4. to release
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable21 |
|
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gmail users added to Nextcloud calendar events currently receive a calendar invite email with broken icon images:
This is due to SVGs not being supported by Gmail. This is a historically common problem with Nextcloud emails, and other past PRs have fixed similar issues, but as of v21 / v20.0.8, the calendar event invite email still has broken icons. This PR addresses fixes issue by adding PNG equivalents for all the icons, and updating the email template to use the PNGs instead. Though they are no longer used, I left the old SVGs alone instead of deleting them, in case we want to add a config flag to use SVGs, or regenerate the PNG at a different resolution in the future.
Related issues: