Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PNGs for icons in activity emails #5483

Merged
merged 3 commits into from
Jul 7, 2017

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 20, 2017

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov
Copy link

codecov bot commented Jun 20, 2017

Codecov Report

Merging #5483 into master will decrease coverage by 46.72%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #5483       +/-   ##
============================================
- Coverage     54.14%   7.41%   -46.73%     
- Complexity    22345   22394       +49     
============================================
  Files          1380    1380               
  Lines         85551   85050      -501     
  Branches       1329    1329               
============================================
- Hits          46318    6305    -40013     
- Misses        39233   78745    +39512
Impacted Files Coverage Δ Complexity Δ
apps/sharebymail/lib/Activity.php 0% <0%> (ø) 39 <0> (+8) ⬆️
settings/Activity/SecurityProvider.php 0% <0%> (-88.47%) 7 <1> (+2)
apps/files/lib/Activity/FavoriteProvider.php 0% <0%> (ø) 18 <0> (+4) ⬆️
apps/files/lib/Activity/Provider.php 0% <0%> (-17.55%) 71 <0> (+16)
apps/dav/lib/CalDAV/Activity/Provider/Todo.php 0% <0%> (ø) 25 <0> (+1) ⬆️
settings/Activity/Provider.php 0% <0%> (ø) 23 <1> (+1) ⬆️
apps/comments/lib/Activity/Provider.php 0% <0%> (-6%) 22 <0> (+1)
...ps/files_sharing/lib/Activity/Providers/Groups.php 0% <0%> (ø) 17 <0> (+2) ⬆️
apps/dav/lib/CalDAV/Activity/Provider/Event.php 0% <0%> (ø) 18 <0> (+1) ⬆️
...pps/files_sharing/lib/Activity/Providers/Users.php 0% <0%> (ø) 23 <0> (+2) ⬆️
... and 823 more

@nickvergessen
Copy link
Member Author

@daita @MorrisJobke @LukasReschke please review since we should backport this to 12, to get rid of the broken emails on gmail

@ArtificialOwl
Copy link
Member

Quickly tested with Circles, and it works ! Just that we need to be careful by the size of the png :]

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants