-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HTML entity rendering in file comments sidebar #29029
Conversation
This comment has been minimized.
This comment has been minimized.
/backport to stable22 |
/backport to stable21 |
a73caed
to
b81f217
Compare
b81f217
to
110190b
Compare
This comment has been minimized.
This comment has been minimized.
110190b
to
347b27c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This comment has been minimized.
This comment has been minimized.
347b27c
to
09f8666
Compare
@tobiasKaminsky do clients render these correctly? |
This comment has been minimized.
This comment has been minimized.
09f8666
to
f06f1d6
Compare
f06f1d6
to
e6abd38
Compare
/compile amend / |
e6abd38
to
f332ba2
Compare
As far as I know this was only a problem on web ui side. |
It seems the server returns double-encoding data, can you coordinate with @Pytal and @PVince81 to make sure @tobiasKaminsky ? :) |
Android:
Desktop:
iOS:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I will rebase it
b34dd35
to
ce614ea
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
ce614ea
to
e5873a2
Compare
Fix #28243
This fix decodes HTML entities contained in comment messages and displaynames.
Some characters are double-encoded, e.g.
>
-&gt;
, so we decode the strings twice. Full character to encoded version map:>
-&gt;
double-encoded<
-&lt;
double-encoded&
-&
encoded"
-"
encoded'
-'
not encodedFurther work
Update backend XML encoder logic to address inconsistent encoding #29306