Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable21] Fix HTML entity rendering in file comments sidebar #29599

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 8, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #29029

@skjnldsv
Copy link
Member

skjnldsv commented Nov 9, 2021

/compile amend /

@skjnldsv
Copy link
Member

skjnldsv commented Nov 9, 2021

/compile amend /

Seems like it's setting up 16.0.0 as node now.

@CarlSchwan CarlSchwan force-pushed the backport/29029/stable21 branch from 98b12a7 to 254c655 Compare November 9, 2021 10:36
@CarlSchwan
Copy link
Member

/compile amend /

Seems like it's setting up 16.0.0 as node now.

I just compiled it locally, let's hope the ci pass :)

@CarlSchwan CarlSchwan force-pushed the backport/29029/stable21 branch from 254c655 to 199f07c Compare November 9, 2021 12:41
@artonge
Copy link
Contributor

artonge commented Nov 9, 2021

/compile amend /

Seems like it's setting up 16.0.0 as node now.

I just compiled it locally, let's hope the ci pass :)

You need to compile with node v12

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@CarlSchwan CarlSchwan force-pushed the backport/29029/stable21 branch from 199f07c to 344e850 Compare November 9, 2021 13:25
@CarlSchwan
Copy link
Member

/compile amend /

Seems like it's setting up 16.0.0 as node now.

I just compiled it locally, let's hope the ci pass :)

You need to compile with node v12

Got it, thanks!

@artonge artonge merged commit ad50457 into stable21 Nov 9, 2021
@artonge artonge deleted the backport/29029/stable21 branch November 9, 2021 14:20
@blizzz blizzz mentioned this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants