Add option to fetch specific user from LDAP

[goyome]

Signed-off-by: Guillaume COLSON guillaume.colson@univ-lorraine.fr
Address issue #27948
This PR is meant to replace #29326 after discussing about it with @blizzz

[blizzz]

check whether loginName2UserName() returned false – this is when the user was not found. Probably best to exit with a message in this case.

[goyome]

In this case, we fall back to the default behavior.
As the user isn't mapped, the next call to $this->confirmUserIsMapped($uid); will trigger the error
The given user is not a recognized LDAP user.

I thought that it would be enough. What do you think ?

[blizzz]

Since --fetch has to be proactively used, my expectancy was that it really and only tries to fetch the user from LDAP first. The fallback might be undesired here (even if it does not hurt). Exiting with a new return code (2) is the best way to deal with this imo.

[goyome]

I've added a commit to implement what you suggested.

[come-nc]

I think this is obsolete because of #29837 which is already merged.
@goyome Can you confirm?

[goyome]

@come-nc Thanks for your improvement and sorry for the late reply. I had few times to make the appropriate tests.

I tried to fetch a new ldap user with
php occ ldap:check-user --update new_user
but the script stop with the error
The given user is not a recognized LDAP user.
which is returned by the function $this->confirmUserIsMapped($uid); which is executed before $exists = $this->backend->userExistsOnLDAP($uid, true);

Anyway, I tried to move the call to confirmUserIsMapped after the update but no changes.

Maybe you should add a call to $this->backend->loginName2UserName($uid) in the update call instead of adding the new fetch option but to me the functionnality needs to be implemented in one way or the other.

[come-nc]

@goyome I think I tested check-ldap for newly-deleted users but not for newly-created users.

When I find time I will look into fixing this as well.

[goyome]

Thanks a lot 👍