Fix ldap:check-user method for newly created LDAP users

[come-nc]

This completes #29837 by also ignoring cache for newly created users instead of only newly deleted users.

This replaces #29837 (and #29326 and #29451) and should fix #27948

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

[come-nc]

@goyome Does this answer your problem? Can you test it?

[PVince81]

👍

[come-nc]

/rebase

[goyome]

Hi @come-nc , thanks for the investigation but it still doesn't work for me

php occ ldap:check-user --force --update colson2i
The given user is not a recognized LDAP user.

$this->backend->userExistsOnLDAP($uid, true) returns nothing while $this->backend->loginName2UserName($uid) seems to do the job…
Sadly, I can't explain why

[come-nc]

@goyome Thank you for testing.

The thing is that ldap:check-user, as most occ user related commands, is expecting an internal nextcloud username, but a non-mapped yet user has none.
So in this case you need to give the LDAP DN:

$ add_ldap_user_in_docker.sh newuser3
adding new entry "cn=newuser3,ou=people,dc=planetexpress,dc=com"
$ docker exec /nextcloud_nextcloud_1 occ ldap:check-user "cn=newuser3,ou=people,dc=planetexpress,dc=com" --update
The user is still available on LDAP.
  entryuuid: 
    44d09de6-195c-103c-99ca-c3b0c166a522
  dn: 
    cn=newuser3,ou=people,dc=planetexpress,dc=com
  uid: 
    newuser3
  mail: 
    newuser3@planetexpress.com
  cn: 
    newuser3

An other option seem to be using a search first to trigger the mapping, but this only works if the search is not yet cached:

$ add_ldap_user_in_docker.sh newuser4
adding new entry "cn=newuser4,ou=people,dc=planetexpress,dc=com"
$ docker exec /nextcloud_nextcloud_1 occ ldap:search newuser
newuser1 (newuser1)
newuser2 (newuser2)
newuser3 (newuser3)
newuser4 (newuser4)
$ docker exec /nextcloud_nextcloud_1 occ ldap:check-user newuser4 --update
The user is still available on LDAP.
  entryuuid: 
    92d0c9a8-195c-103c-99cb-c3b0c166a522
  dn: 
    cn=newuser4,ou=people,dc=planetexpress,dc=com
  uid: 
    newuser4
  mail: 
    newuser4@planetexpress.com
  cn: 
    newuser4
$ add_ldap_user_in_docker.sh newuser5
adding new entry "cn=newuser5,ou=people,dc=planetexpress,dc=com"
$ docker exec /nextcloud_nextcloud_1 occ ldap:search newuser
newuser1 (newuser1)
newuser2 (newuser2)
newuser3 (newuser3)
newuser4 (newuser4)
$ docker exec /nextcloud_nextcloud_1 occ ldap:check-user newuser5 --update
The given user is not a recognized LDAP user.

[goyome]

Thanks @come-nc, that was it.
I was using uid instead of dn but the help mislead me.

Usage:
  ldap:check-user [options] [--] <ocName>

Arguments:
  ocName                the user name as used in Nextcloud

Maybe you should specify that we have to use dn in the description of the --update option or use element of config (ldap_base_users and ldap_login_filter/ldap_expert_username_attr) to create the dn from the uid

[come-nc]

@blizzz Could you have review on this one, because in the end I had to change a bit fetching to make sure it worked with a user DN as for a non-yet-mapped user there is no owncloud_name yet.
It worked before the last commit already, but a bit by chance, because some functions are supposed to take an owncloud_name but are actually working with a dn as well. So I added an explicit DN fetch to make it clean and future proof.

[PVince81]

👍

[come-nc]

/backport to stable23

[come-nc]

/backport to stable22