-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new button component #31397
add new button component #31397
Conversation
9ced582
to
a441c94
Compare
/compile amend / |
Signed-off-by: Vanessa Pertsch <vanessa.pertsch@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
a441c94
to
bf7150e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
@@ -70,7 +77,7 @@ | |||
import { showError } from '@nextcloud/dialogs' | |||
import EmojiPicker from '@nextcloud/vue/dist/Components/EmojiPicker' | |||
import Modal from '@nextcloud/vue/dist/Components/Modal' | |||
|
|||
import ButtonVue from '@nextcloud/vue/dist/Components/Button' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the renaming here? Is it conflicting with other native button components? Should we rename the component itself @skjnldsv?
Looks good generally, but – @marcoambrosini it does look a bit weird that a clear/delete button is primary-colored, right? |
@jancborchardt don't you think we can just use tertiary there? |
@jancborchardt can we use tertiary here? |
@vanpertsch @marcoambrosini tertiary looks good! :) @marcoambrosini and yes, I'd say error should be less punchy, at least when we use it for remove, delete and "decline event". Not sure about " Leave call", maybe that needs to stay more obvious as it's the only main action in the case. |
Before
After