Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no secondary button for now-> use primary and tertiary instead. #31597

Closed
wants to merge 1 commit into from

Conversation

vanpertsch
Copy link
Contributor

@vanpertsch vanpertsch commented Mar 16, 2022

buttons changed to primary
#31340

buttons changed to tertiary
add new button component #31397

Signed-off-by: Vanessa Pertsch vanessa.pertsch@nextcloud.com

@vanpertsch vanpertsch added the 3. to review Waiting for reviews label Mar 16, 2022
@vanpertsch vanpertsch added this to the Nextcloud 24 milestone Mar 16, 2022
@vanpertsch vanpertsch self-assigned this Mar 16, 2022
@vanpertsch vanpertsch requested review from PVince81, Pytal and szaimen and removed request for a team March 16, 2022 16:36
@marcoambrosini
Copy link
Member

@vanpertsch should we keep an issue with a list of all the buttons to be reverted to secondary when that's available?

@vanpertsch
Copy link
Contributor Author

/compile amend /

@vanpertsch
Copy link
Contributor Author

/compile amend /

Signed-off-by: Vanessa Pertsch <vanessa.pertsch@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@vanpertsch
Copy link
Contributor Author

not longer needed

nextcloud-libraries/nextcloud-vue#2562

@vanpertsch vanpertsch closed this Mar 21, 2022
@vanpertsch vanpertsch deleted the fix-secondary-buttons branch March 21, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants