Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to not match userID during full match #31857

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 6, 2022

This option allow to not match the userID when disabling username autocompletion in share dialog, but enabling autocompletion on exact match.

Setting userID search Display Name search
Screenshot from 2022-04-06 12-41-26 Screenshot from 2022-04-06 12-47-03 Screenshot from 2022-04-06 12-47-20
Screenshot from 2022-04-06 12-41-19 Screenshot from 2022-04-06 12-47-29 Screenshot from 2022-04-06 12-47-20

Default to true.
Is hidden when full match is disabled:
Screenshot from 2022-04-06 12-52-32

Fix https://github.com/nextcloud-gmbh/customer-feature-requests/issues/6

@artonge artonge added this to the Nextcloud 25 milestone Apr 6, 2022
@artonge artonge self-assigned this Apr 6, 2022
@artonge artonge force-pushed the feat/dont_match_userid branch 2 times, most recently from a2bd620 to 2ce1f2d Compare April 6, 2022 10:55
@artonge artonge requested review from a team, PVince81, blizzz and skjnldsv and removed request for a team April 6, 2022 10:56
@artonge artonge added the 3. to review Waiting for reviews label Apr 6, 2022
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Copy link
Contributor Author

artonge commented Apr 6, 2022

/backport to stable23

@artonge
Copy link
Contributor Author

artonge commented Apr 6, 2022

/backport to stable22

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blizzz
Copy link
Member

blizzz commented Apr 8, 2022

integration tests need more adjustments

@PVince81 PVince81 merged commit cde2605 into master Apr 11, 2022
@PVince81 PVince81 deleted the feat/dont_match_userid branch April 11, 2022 08:28
@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@skjnldsv
Copy link
Member

@artonge Documentation missing?

artonge added a commit to nextcloud/documentation that referenced this pull request Feb 12, 2024
From the following PRs:
- nextcloud/server#31932
- nextcloud/server#31857
- nextcloud/server#31857

Signed-off-by: Louis Chemineau <louis@chmn.me>
acataluddi pushed a commit to acataluddi/nextcloud-documentation that referenced this pull request Apr 28, 2024
From the following PRs:
- nextcloud/server#31932
- nextcloud/server#31857
- nextcloud/server#31857

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Adriano Cataluddi <acataluddi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants