Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to ignore email during search #31964

Merged
merged 2 commits into from
May 5, 2022

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 13, 2022

Same as #31857 be for email.

Technical changes when the option is disabled

Result

Enabled Disabled
Screenshot from 2022-04-13 15-34-33 Screenshot from 2022-04-13 15-34-41

@artonge artonge force-pushed the feat/ignore_mail_during_contact_lookup branch from 69e3ff8 to 12b97ea Compare April 13, 2022 13:40
@artonge artonge self-assigned this Apr 13, 2022
@artonge artonge added the 2. developing Work in progress label Apr 13, 2022
@artonge artonge added this to the Nextcloud 25 milestone Apr 13, 2022
@artonge artonge force-pushed the feat/ignore_mail_during_contact_lookup branch 2 times, most recently from 04382e3 to b262c37 Compare April 13, 2022 16:02
@artonge
Copy link
Contributor Author

artonge commented Apr 27, 2022

@jancborchardt should we keep those settings in the Share admin settings view?
We could remove them from the web UI and let the user set them from the CLI with occ.
We could also move them in the config.php.

@jancborchardt
Copy link
Member

@artonge CLI setting for both this and the other setting seems enough, yes.

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the feat/ignore_mail_during_contact_lookup branch from c354d62 to 039a830 Compare May 3, 2022 15:51
@artonge

This comment was marked as duplicate.

@artonge artonge requested review from a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team May 4, 2022 09:54
@artonge
Copy link
Contributor Author

artonge commented May 4, 2022

CI failure unrelated

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@artonge artonge merged commit 841a4a4 into master May 5, 2022
@artonge artonge deleted the feat/ignore_mail_during_contact_lookup branch May 5, 2022 15:52
@artonge
Copy link
Contributor Author

artonge commented May 9, 2022

/backport to stable22

@artonge
Copy link
Contributor Author

artonge commented May 9, 2022

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@artonge
Copy link
Contributor Author

artonge commented May 11, 2022

/backport to stable24

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@skjnldsv
Copy link
Member

@artonge Documentation missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants