-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable24] load dashboard widgets of enabled apps only #32997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- per design, all enabled apps have their registration run - limitations, e.g. enabled by group, are not considered in that state, because we do not have a session (and might need apps?) - before instantiation of widget it has to be checked whether the providing app is actually enabled for the logged in user. - a public interface is being changed, but it is not meant to be implemented or used outside of the core handling. Therefore save to backport. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- might break install Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
backport/32980/stable24
branch
from
June 28, 2022 21:50
98997bc
to
771d389
Compare
/backport to stable23 |
blizzz
requested review from
juliusknorr,
julien-nc,
CarlSchwan,
come-nc and
a team
June 28, 2022 21:52
skjnldsv
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
juliusknorr
approved these changes
Jul 7, 2022
/backport to stable22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #32980