Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] load dashboard widgets of enabled apps only #32997

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jun 23, 2022

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #32980

- per design, all enabled apps have their registration run
- limitations, e.g. enabled by group, are not considered in that state,
  because we do not have a session (and might need apps?)
- before instantiation of widget it has to be checked whether the providing
  app is actually enabled for the logged in user.
- a public interface is being changed, but it is not meant to be
  implemented or used outside of the core handling. Therefore save to
  backport.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
lib/private/Dashboard/Manager.php Fixed Show fixed Hide fixed
lib/private/Dashboard/Manager.php Fixed Show fixed Hide fixed
lib/private/Dashboard/Manager.php Fixed Show fixed Hide fixed
lib/private/Dashboard/Manager.php Fixed Show fixed Hide fixed
lib/private/Dashboard/Manager.php Fixed Show fixed Hide fixed
- might break install

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the backport/32980/stable24 branch from 98997bc to 771d389 Compare June 28, 2022 21:50
@blizzz blizzz added the 3. to review Waiting for reviews label Jun 28, 2022
@blizzz
Copy link
Member

blizzz commented Jun 28, 2022

/backport to stable23

@blizzz blizzz requested review from juliusknorr, julien-nc, CarlSchwan, come-nc and a team June 28, 2022 21:52
@skjnldsv skjnldsv mentioned this pull request Jul 5, 2022
18 tasks
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv merged commit 447a238 into stable24 Jul 7, 2022
@skjnldsv skjnldsv deleted the backport/32980/stable24 branch July 7, 2022 08:49
@szaimen
Copy link
Contributor

szaimen commented Jul 12, 2022

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants