Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable22] load dashboard widgets of enabled apps only #33208

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #32997

blizzz added 2 commits July 12, 2022 08:52
- per design, all enabled apps have their registration run
- limitations, e.g. enabled by group, are not considered in that state,
  because we do not have a session (and might need apps?)
- before instantiation of widget it has to be checked whether the providing
  app is actually enabled for the logged in user.
- a public interface is being changed, but it is not meant to be
  implemented or used outside of the core handling. Therefore save to
  backport.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- might break install

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@szaimen szaimen changed the title [stable22] [stable24] load dashboard widgets of enabled apps only [stable22] load dashboard widgets of enabled apps only Jul 12, 2022
@julien-nc
Copy link
Member

Drone failure is unrelated (Samba storage tests).

@blizzz blizzz mentioned this pull request Jul 18, 2022
@blizzz
Copy link
Member

blizzz commented Sep 8, 2022

Drone failure is unrelated (Samba storage tests).

@eneiluj is this equivalent to a green checkmark?

@julien-nc
Copy link
Member

@blizzz Yes 😁

@blizzz blizzz merged commit 2be5fd5 into stable22 Sep 8, 2022
@blizzz blizzz deleted the backport/32997/stable22 branch September 8, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants