Disable style override on vue-select elements #35165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable25 |
13 tasks
artonge
approved these changes
Nov 15, 2022
Yes :) added a comment https://github.com/nextcloud/server/blob/fix/vue-select-styles/core/css/inputs.scss#L32 |
Pytal
added a commit
to nextcloud-libraries/nextcloud-vue
that referenced
this pull request
Nov 16, 2022
- PENDING nextcloud/server#35165 Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
added a commit
to nextcloud-libraries/nextcloud-vue
that referenced
this pull request
Nov 16, 2022
- PENDING nextcloud/server#35165 Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
added a commit
to nextcloud-libraries/nextcloud-vue
that referenced
this pull request
Nov 18, 2022
- PENDING nextcloud/server#35165 Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/vue-select-styles
branch
2 times, most recently
from
4d7da2f
to
8784aa2
Compare
|
Rebased |
PVince81
approved these changes
Dec 5, 2022
- Disable style override on NcActionButton with `:not(.action-button)` due to increased specificity over scoped Vue styles when only `:not([class^="vs__"])` is added Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/vue-select-styles
branch
from
8784aa2
to
d3d5034
Compare
|
Also disable style override on NcActionButton with |
Pytal
added
4. to release
1 task
|
Unfortunately, this selector is too strong, it override the default scoping most vue apps do
We need to revert and find a different selector without brackets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the styling of vue-select elements as we will soon use the https://github.com/sagalbot/vue-select library in place of the https://github.com/shentao/vue-multiselect library