Revert "Disable style override on vue-select elements" #35665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
PVince81 and
artonge
and removed request for
a team
CarlSchwan
approved these changes
Dec 8, 2022
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
revert-35165-fix/vue-select-styles
branch
from
18a93a7
to
2d5fe7e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
added
4. to release
Pytal
approved these changes
Dec 8, 2022
1 task
This was referenced Dec 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #35165 (comment)
Ref: #35627
Unfortunately, this selector is too strong, it override the default scoping most vue apps do.
You could argue that you should use an
NcButton, but I think this might create too much issues, and it also means there are probably other areas where this broke and we did not notice 😕We need to revert and find a different selector without brackets
