Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMC-127 - File action button behaviour for different viewport #38123

Conversation

TSI-kavitasonawane
Copy link
Contributor

@TSI-kavitasonawane TSI-kavitasonawane commented May 8, 2023

This PR contains the following changes:
File action button behaviour changes:

  • We now show more single actions depending on the viewport size in the table header beginning from the first option in the dropdown.
  • We add a new option called "Cancel" which will remove any selection (just remove selection, not the files of course).
  • We right align the Actions button.
  • We will show every option in the action button dropdown. It doesnt matter which option is also shown in the table header.
  • We add a new label called "All".
  • on S: we hide the label "All" according to the screen design

Screenshot after changes:

filesaction
actionchange

Signed-off-by: kavita.sonawane@t-systems.com <kavita.sonawane@t-systems.com>
@szaimen szaimen added 3. to review Waiting for reviews enhancement labels May 8, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 8, 2023
@szaimen szaimen requested review from skjnldsv, a team, susnux and nfebe and removed request for a team May 8, 2023 09:22
@skjnldsv
Copy link
Member

skjnldsv commented May 9, 2023

Not sure if worth having considering 28 and Files to vue
cc @AndyScherzinger

@AndyScherzinger
Copy link
Member

Not sure if worth having considering 28 and Files to vue

@jancborchardt what do you think in general? If this is agreed on to be added from a designer's perspective than I would agree with @skjnldsv that we skip the PR and implement this directly within the files2vue migration for v28.

@tsdicloud
Copy link
Contributor

@kavita: Please pull back the PR as long as the criteria mentioned in our downstream ticket are met.
Only fully completed and quality-approved changes neutralized fur upstream use can become a PR for Nextcloud.

@tsdicloud tsdicloud deleted the nmc/127-file-multiselection-action-pr branch July 14, 2023 12:32
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Nov 1, 2023

FIxed in 28

@skjnldsv skjnldsv closed this Nov 1, 2023
@skjnldsv skjnldsv removed the 3. to review Waiting for reviews label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants