-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
127-file multiselection action #217
Conversation
We had already raised as PR for upstream to nextcloud but they have closed it .. |
808f333
to
caaf75d
Compare
Still in acceptable many changed lines on core, though most of it is extension. |
Would also recommend to re-read the new delivery model concept. An ATM, I expect a complete restart for this change as nothing has improved compared to V24 according to the new "Minimized change" rules. |
Parts of the merge look specific to old grid layout. |
We raised PR for upstream to nextcloud . |
Kavita, STOP raising pull requests wildly. The obvious, quality way of raising an PR is:
|
I don't see that the finished PR is handled appropriately as the cancel code is still in the master patch. As soon as Nextcloud contains an upstream patch, the refactoring steps are: I don't see any care for the nextcloud#28834 yet. |
caaf75d
to
7b32738
Compare
d0748cd
to
8c7e2cd
Compare
ac0c03f
to
ec3289d
Compare
Overwrite of Nextcloud code, should be an extension as add-on functionality to Nextcloud standard. |
Needs redo, review only. |
This PR contains the following changes:
File action button behaviour changes:
We now show more single actions depending on the viewport size in the table header beginning from the first option in the dropdown.
We add a new option called "Cancel" (ger: Abbrechen") which will remove any selection (just remove selection, not the files of course).
We right align the Actions button.
We will show every option in the action button dropdown. It doesnt matter which option is also shown in the table header.
We add a new label called "All".
on S: we hide the label "All" according to the screen design