Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize registerMounts by removing unused function #3944

Closed
wants to merge 1 commit into from
Closed

Optimize registerMounts by removing unused function #3944

wants to merge 1 commit into from

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 20, 2017 •
edited
Loading

@icewind1991 Seems to be code that is only used for unit test stuff -> so better make the unit tests better (if they are not already 😉 )

@mrow4a @MorrisJobke
Optimize registerMounts by removing unused function
e38584f 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews downstream labels Mar 20, 2017
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @nickvergessen and @LukasReschke to be potential reviewers.

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Mar 20, 2017
ChristophWurst
ChristophWurst approved these changes Mar 20, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ew, this testing code really shouldn't live here :-)

@MorrisJobke
Copy link
Member Author

The unit test is fixed with #2847 🙈

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 20, 2017
@MorrisJobke MorrisJobke mentioned this pull request May 1, 2017
Closed
@MorrisJobke
Copy link
Member Author

Moved to #2847

@MorrisJobke MorrisJobke closed this May 1, 2017
@MorrisJobke MorrisJobke deleted the downstream-27373 branch May 1, 2017 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MorrisJobke @mention-bot @nickvergessen @ChristophWurst @mrow4a